Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add vscode workspace settings #7173

Merged
merged 11 commits into from
Oct 22, 2024
Merged

chore: add vscode workspace settings #7173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c0f2749
Add vscode workspace settings
nazarhussain Oct 17, 2024
5a8c586
Update the settings file
nazarhussain Oct 17, 2024
82d3665
Add settings for open-in-github
nazarhussain Oct 17, 2024
27a1344
Update the settings
nazarhussain Oct 17, 2024
f92bd13
Add comment in the settings
nazarhussain Oct 17, 2024
32b8e4d
Update the settings
nazarhussain Oct 18, 2024
fd02f98
Use tabaqa extension to override settings
nazarhussain Oct 18, 2024
f6b4561
Revert "Use tabaqa extension to override settings"
nazarhussain Oct 22, 2024
6d2f0be
Update the settings file
nazarhussain Oct 22, 2024
da801a4
Update settings
nazarhussain Oct 22, 2024
207e28c
Update .vscode/settings.json
nazarhussain Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ validators
.tmp
.npmrc
.vscode/launch.json
.vscode/settings.json
!.vscode/settings.json
.vscode/tasks.json

# Tests artifacts
Expand Down
22 changes: 22 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"window.title": "${activeEditorShort}${separator}${rootName}${separator}${profileName}${separator}[${activeRepositoryBranchName}]",
"editor.defaultFormatter": "esbenp.prettier-vscode",
// For `sysoev.vscode-open-in-github` extension
"openInGitHub.defaultBranch": "unstable",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted in previous comment, not a fan of putting this in the middle of editor. settings but I guess it's fine

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL... its funny that this PR had more discussion than a lot

"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.fixAll.biome": "explicit",
},
"[javascript]": {
"editor.defaultFormatter": "biomejs.biome"
},
"[typescript]": {
"editor.defaultFormatter": "biomejs.biome"
},
"[json]": {
"editor.defaultFormatter": "biomejs.biome"
},
"[jsonc]": {
"editor.defaultFormatter": "biomejs.biome"
}
nazarhussain marked this conversation as resolved.
Show resolved Hide resolved
}
3 changes: 3 additions & 0 deletions biome.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
"ignore": ["**/lib", "**/.nyc_output", "./packages/*/spec-tests", "**/node_modules", "./packages/*/node_modules/**"]
},
"organizeImports": {
// TODO: We will enable this settings as soon mono-repo support is provided in biome.
// Currently it didn't recognize local packages in repo and sort those higher than npm packages
// https://github.com/biomejs/biome/issues/2228
"enabled": false
},
"linter": {
Expand Down
12 changes: 0 additions & 12 deletions lodestar.code-workspace
View file
Open in desktop

This file was deleted.

Loading