-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: return el_offline
as true
in syncing status response if auth failed
#7175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
changed the title
fix: consider execution client as offline if auth failed
fix: return Oct 17, 2024
el_offline
as true
in syncing status response if auth failed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #7175 +/- ##
=========================================
Coverage 49.21% 49.21%
=========================================
Files 598 598
Lines 39726 39726
Branches 2092 2095 +3
=========================================
+ Hits 19550 19551 +1
+ Misses 20136 20135 -1
Partials 40 40 |
Performance Report✔️ no performance regression detected Full benchmark results
|
ensi321
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If the EL client authentication fails it does not make sense to mark it as online in the syncing status reponse. This is also aligned with what's stated in sigp/lighthouse#4295.
In the spec, the definition is vague and it might be good to clarify it there as well.
Description
Return
el_offline
astrue
in syncing status api response if authentication failed