Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove warning log if validator pubkey not found or invalid #7198

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix: remove warning log if validator pubkey not found or invalid #7198

merged 1 commit into from
Oct 25, 2024

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Oct 25, 2024

Motivation

This log is too noisy and quite common if the validator client has loaded pubkeys which are not yet active. We can't log this as warn, an alternative would be to log it was debug but the scenario where this log would be useful, e.g. a user querying the api manually, a debug log will hardly be visible and likely the user it better of just double checking the pubkey sent (ie. in case it is malformed).

Description

Remove warning log if validator pubkey not found or invalid, this reverts e595ab7 added in #7107

@nflaig nflaig requested a review from a team as a code owner October 25, 2024 09:15
@github-actions GitHub Actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 991ceba Previous: 6de0736 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 2.0238 ms/op 2.1616 ms/op 0.94
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 50.213 us/op 60.244 us/op 0.83
BLS verify - blst 813.18 us/op 829.72 us/op 0.98
BLS verifyMultipleSignatures 3 - blst 1.2149 ms/op 1.4510 ms/op 0.84
BLS verifyMultipleSignatures 8 - blst 1.6427 ms/op 1.7123 ms/op 0.96
BLS verifyMultipleSignatures 32 - blst 5.0990 ms/op 5.0269 ms/op 1.01
BLS verifyMultipleSignatures 64 - blst 9.0713 ms/op 9.7252 ms/op 0.93
BLS verifyMultipleSignatures 128 - blst 17.458 ms/op 19.288 ms/op 0.91
BLS deserializing 10000 signatures 690.41 ms/op 712.98 ms/op 0.97
BLS deserializing 100000 signatures 6.8300 s/op 7.1636 s/op 0.95
BLS verifyMultipleSignatures - same message - 3 - blst 833.01 us/op 1.0705 ms/op 0.78
BLS verifyMultipleSignatures - same message - 8 - blst 947.53 us/op 1.2074 ms/op 0.78
BLS verifyMultipleSignatures - same message - 32 - blst 1.6278 ms/op 1.8633 ms/op 0.87
BLS verifyMultipleSignatures - same message - 64 - blst 2.4649 ms/op 2.8996 ms/op 0.85
BLS verifyMultipleSignatures - same message - 128 - blst 4.1529 ms/op 4.6934 ms/op 0.88
BLS aggregatePubkeys 32 - blst 19.013 us/op 20.673 us/op 0.92
BLS aggregatePubkeys 128 - blst 67.639 us/op 72.459 us/op 0.93
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 63.135 ms/op 59.417 ms/op 1.06
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 53.846 ms/op 58.657 ms/op 0.92
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 42.651 ms/op 55.984 ms/op 0.76
getSlashingsAndExits - default max 88.837 us/op 115.39 us/op 0.77
getSlashingsAndExits - 2k 284.13 us/op 432.98 us/op 0.66
proposeBlockBody type=full, size=empty 5.9302 ms/op 7.0969 ms/op 0.84
isKnown best case - 1 super set check 284.00 ns/op 493.00 ns/op 0.58
isKnown normal case - 2 super set checks 277.00 ns/op 529.00 ns/op 0.52
isKnown worse case - 16 super set checks 306.00 ns/op 519.00 ns/op 0.59
InMemoryCheckpointStateCache - add get delete 3.0190 us/op 3.4760 us/op 0.87
updateUnfinalizedPubkeys - updating 10 pubkeys 1.1509 ms/op 1.5571 ms/op 0.74
updateUnfinalizedPubkeys - updating 100 pubkeys 3.3033 ms/op 4.1904 ms/op 0.79
updateUnfinalizedPubkeys - updating 1000 pubkeys 53.411 ms/op 55.423 ms/op 0.96
validate api signedAggregateAndProof - struct 1.4398 ms/op 1.6093 ms/op 0.89
validate gossip signedAggregateAndProof - struct 1.4907 ms/op 1.5216 ms/op 0.98
batch validate gossip attestation - vc 640000 - chunk 32 128.35 us/op 138.10 us/op 0.93
batch validate gossip attestation - vc 640000 - chunk 64 118.19 us/op 122.16 us/op 0.97
batch validate gossip attestation - vc 640000 - chunk 128 117.65 us/op 117.54 us/op 1.00
batch validate gossip attestation - vc 640000 - chunk 256 119.02 us/op 116.55 us/op 1.02
pickEth1Vote - no votes 1.2834 ms/op 1.1634 ms/op 1.10
pickEth1Vote - max votes 8.9574 ms/op 7.2728 ms/op 1.23
pickEth1Vote - Eth1Data hashTreeRoot value x2048 18.348 ms/op 16.657 ms/op 1.10
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 23.278 ms/op 24.661 ms/op 0.94
pickEth1Vote - Eth1Data fastSerialize value x2048 618.51 us/op 546.50 us/op 1.13
pickEth1Vote - Eth1Data fastSerialize tree x2048 2.7932 ms/op 4.6584 ms/op 0.60
bytes32 toHexString 565.00 ns/op 572.00 ns/op 0.99
bytes32 Buffer.toString(hex) 280.00 ns/op 269.00 ns/op 1.04
bytes32 Buffer.toString(hex) from Uint8Array 452.00 ns/op 463.00 ns/op 0.98
bytes32 Buffer.toString(hex) + 0x 283.00 ns/op 260.00 ns/op 1.09
Object access 1 prop 0.16200 ns/op 0.18700 ns/op 0.87
Map access 1 prop 0.13600 ns/op 0.14000 ns/op 0.97
Object get x1000 6.1060 ns/op 6.2410 ns/op 0.98
Map get x1000 6.8420 ns/op 6.4930 ns/op 1.05
Object set x1000 52.013 ns/op 44.380 ns/op 1.17
Map set x1000 32.383 ns/op 31.306 ns/op 1.03
Return object 10000 times 0.31140 ns/op 0.31080 ns/op 1.00
Throw Error 10000 times 3.5381 us/op 3.4855 us/op 1.02
toHex 176.76 ns/op 165.68 ns/op 1.07
Buffer.from 152.85 ns/op 158.42 ns/op 0.96
shared Buffer 106.62 ns/op 107.01 ns/op 1.00
fastMsgIdFn sha256 / 200 bytes 2.6200 us/op 2.3000 us/op 1.14
fastMsgIdFn h32 xxhash / 200 bytes 346.00 ns/op 295.00 ns/op 1.17
fastMsgIdFn h64 xxhash / 200 bytes 312.00 ns/op 285.00 ns/op 1.09
fastMsgIdFn sha256 / 1000 bytes 8.1200 us/op 7.5510 us/op 1.08
fastMsgIdFn h32 xxhash / 1000 bytes 462.00 ns/op 430.00 ns/op 1.07
fastMsgIdFn h64 xxhash / 1000 bytes 385.00 ns/op 355.00 ns/op 1.08
fastMsgIdFn sha256 / 10000 bytes 72.693 us/op 66.943 us/op 1.09
fastMsgIdFn h32 xxhash / 10000 bytes 2.1530 us/op 1.9380 us/op 1.11
fastMsgIdFn h64 xxhash / 10000 bytes 1.3220 us/op 1.2870 us/op 1.03
send data - 1000 256B messages 16.962 ms/op 14.252 ms/op 1.19
send data - 1000 512B messages 20.763 ms/op 18.871 ms/op 1.10
send data - 1000 1024B messages 35.421 ms/op 30.475 ms/op 1.16
send data - 1000 1200B messages 33.428 ms/op 28.696 ms/op 1.16
send data - 1000 2048B messages 37.954 ms/op 34.025 ms/op 1.12
send data - 1000 4096B messages 39.982 ms/op 35.275 ms/op 1.13
send data - 1000 16384B messages 80.249 ms/op 77.401 ms/op 1.04
send data - 1000 65536B messages 229.92 ms/op 245.76 ms/op 0.94
enrSubnets - fastDeserialize 64 bits 1.4220 us/op 1.3230 us/op 1.07
enrSubnets - ssz BitVector 64 bits 481.00 ns/op 440.00 ns/op 1.09
enrSubnets - fastDeserialize 4 bits 224.00 ns/op 204.00 ns/op 1.10
enrSubnets - ssz BitVector 4 bits 466.00 ns/op 445.00 ns/op 1.05
prioritizePeers score -10:0 att 32-0.1 sync 2-0 209.73 us/op 164.38 us/op 1.28
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 206.50 us/op 308.97 us/op 0.67
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 367.81 us/op 311.56 us/op 1.18
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 488.83 us/op 404.79 us/op 1.21
prioritizePeers score 0:0 att 64-1 sync 4-1 1.0473 ms/op 773.03 us/op 1.35
array of 16000 items push then shift 1.8747 us/op 1.7216 us/op 1.09
LinkedList of 16000 items push then shift 10.540 ns/op 8.2280 ns/op 1.28
array of 16000 items push then pop 164.33 ns/op 142.82 ns/op 1.15
LinkedList of 16000 items push then pop 9.1980 ns/op 7.8530 ns/op 1.17
array of 24000 items push then shift 2.6898 us/op 2.5510 us/op 1.05
LinkedList of 24000 items push then shift 9.8140 ns/op 8.0770 ns/op 1.22
array of 24000 items push then pop 207.48 ns/op 185.10 ns/op 1.12
LinkedList of 24000 items push then pop 8.3770 ns/op 7.7670 ns/op 1.08
intersect bitArray bitLen 8 7.0300 ns/op 6.6070 ns/op 1.06
intersect array and set length 8 74.516 ns/op 52.254 ns/op 1.43
intersect bitArray bitLen 128 34.252 ns/op 31.557 ns/op 1.09
intersect array and set length 128 984.25 ns/op 816.85 ns/op 1.20
bitArray.getTrueBitIndexes() bitLen 128 2.5230 us/op 2.1950 us/op 1.15
bitArray.getTrueBitIndexes() bitLen 248 4.1590 us/op 3.7630 us/op 1.11
bitArray.getTrueBitIndexes() bitLen 512 8.3290 us/op 9.2040 us/op 0.90
Buffer.concat 32 items 1.0560 us/op 1.1000 us/op 0.96
Uint8Array.set 32 items 2.0030 us/op 1.9270 us/op 1.04
Buffer.copy 2.0560 us/op 2.2090 us/op 0.93
Uint8Array.set - with subarray 3.3650 us/op 3.2500 us/op 1.04
Uint8Array.set - without subarray 1.6210 us/op 1.5990 us/op 1.01
getUint32 - dataview 299.00 ns/op 289.00 ns/op 1.03
getUint32 - manual 246.00 ns/op 228.00 ns/op 1.08
Set add up to 64 items then delete first 3.0789 us/op 2.7015 us/op 1.14
OrderedSet add up to 64 items then delete first 4.6247 us/op 4.0128 us/op 1.15
Set add up to 64 items then delete last 3.3287 us/op 3.1446 us/op 1.06
OrderedSet add up to 64 items then delete last 4.8195 us/op 4.6952 us/op 1.03
Set add up to 64 items then delete middle 3.3070 us/op 2.9945 us/op 1.10
OrderedSet add up to 64 items then delete middle 6.7437 us/op 6.2151 us/op 1.09
Set add up to 128 items then delete first 6.8668 us/op 5.9229 us/op 1.16
OrderedSet add up to 128 items then delete first 10.009 us/op 8.7534 us/op 1.14
Set add up to 128 items then delete last 6.6599 us/op 6.0516 us/op 1.10
OrderedSet add up to 128 items then delete last 8.5353 us/op 9.1852 us/op 0.93
Set add up to 128 items then delete middle 5.6219 us/op 5.7839 us/op 0.97
OrderedSet add up to 128 items then delete middle 17.311 us/op 15.654 us/op 1.11
Set add up to 256 items then delete first 13.532 us/op 11.936 us/op 1.13
OrderedSet add up to 256 items then delete first 22.255 us/op 18.480 us/op 1.20
Set add up to 256 items then delete last 14.368 us/op 12.119 us/op 1.19
OrderedSet add up to 256 items then delete last 20.838 us/op 18.068 us/op 1.15
Set add up to 256 items then delete middle 13.596 us/op 11.524 us/op 1.18
OrderedSet add up to 256 items then delete middle 50.974 us/op 44.511 us/op 1.15
transfer serialized Status (84 B) 1.8190 us/op 1.6290 us/op 1.12
copy serialized Status (84 B) 1.4520 us/op 1.3800 us/op 1.05
transfer serialized SignedVoluntaryExit (112 B) 1.8460 us/op 1.6170 us/op 1.14
copy serialized SignedVoluntaryExit (112 B) 1.4960 us/op 1.4280 us/op 1.05
transfer serialized ProposerSlashing (416 B) 2.3460 us/op 2.3680 us/op 0.99
copy serialized ProposerSlashing (416 B) 2.3350 us/op 2.4070 us/op 0.97
transfer serialized Attestation (485 B) 2.1550 us/op 2.4300 us/op 0.89
copy serialized Attestation (485 B) 2.6370 us/op 2.0140 us/op 1.31
transfer serialized AttesterSlashing (33232 B) 2.3850 us/op 2.7080 us/op 0.88
copy serialized AttesterSlashing (33232 B) 8.2420 us/op 7.3180 us/op 1.13
transfer serialized Small SignedBeaconBlock (128000 B) 2.4090 us/op 3.4010 us/op 0.71
copy serialized Small SignedBeaconBlock (128000 B) 27.604 us/op 20.690 us/op 1.33
transfer serialized Avg SignedBeaconBlock (200000 B) 3.3700 us/op 3.5730 us/op 0.94
copy serialized Avg SignedBeaconBlock (200000 B) 38.463 us/op 26.990 us/op 1.43
transfer serialized BlobsSidecar (524380 B) 3.4730 us/op 3.9180 us/op 0.89
copy serialized BlobsSidecar (524380 B) 120.71 us/op 159.92 us/op 0.75
transfer serialized Big SignedBeaconBlock (1000000 B) 4.6470 us/op 3.6940 us/op 1.26
copy serialized Big SignedBeaconBlock (1000000 B) 183.19 us/op 174.95 us/op 1.05
pass gossip attestations to forkchoice per slot 3.1314 ms/op 2.8907 ms/op 1.08
forkChoice updateHead vc 100000 bc 64 eq 0 479.08 us/op 502.35 us/op 0.95
forkChoice updateHead vc 600000 bc 64 eq 0 3.1309 ms/op 3.1980 ms/op 0.98
forkChoice updateHead vc 1000000 bc 64 eq 0 5.1700 ms/op 5.4830 ms/op 0.94
forkChoice updateHead vc 600000 bc 320 eq 0 2.9011 ms/op 2.9797 ms/op 0.97
forkChoice updateHead vc 600000 bc 1200 eq 0 3.0577 ms/op 3.1680 ms/op 0.97
forkChoice updateHead vc 600000 bc 7200 eq 0 4.1277 ms/op 3.5585 ms/op 1.16
forkChoice updateHead vc 600000 bc 64 eq 1000 10.797 ms/op 10.765 ms/op 1.00
forkChoice updateHead vc 600000 bc 64 eq 10000 11.027 ms/op 10.722 ms/op 1.03
forkChoice updateHead vc 600000 bc 64 eq 300000 18.465 ms/op 14.537 ms/op 1.27
computeDeltas 500000 validators 300 proto nodes 4.3518 ms/op 4.1181 ms/op 1.06
computeDeltas 500000 validators 1200 proto nodes 4.3912 ms/op 3.9335 ms/op 1.12
computeDeltas 500000 validators 7200 proto nodes 4.2977 ms/op 3.9429 ms/op 1.09
computeDeltas 750000 validators 300 proto nodes 6.1309 ms/op 5.8045 ms/op 1.06
computeDeltas 750000 validators 1200 proto nodes 5.9935 ms/op 5.8235 ms/op 1.03
computeDeltas 750000 validators 7200 proto nodes 6.1959 ms/op 5.9784 ms/op 1.04
computeDeltas 1400000 validators 300 proto nodes 11.598 ms/op 11.229 ms/op 1.03
computeDeltas 1400000 validators 1200 proto nodes 11.564 ms/op 11.024 ms/op 1.05
computeDeltas 1400000 validators 7200 proto nodes 11.681 ms/op 10.920 ms/op 1.07
computeDeltas 2100000 validators 300 proto nodes 17.019 ms/op 16.325 ms/op 1.04
computeDeltas 2100000 validators 1200 proto nodes 17.185 ms/op 16.424 ms/op 1.05
computeDeltas 2100000 validators 7200 proto nodes 17.271 ms/op 16.587 ms/op 1.04
altair processAttestation - 250000 vs - 7PWei normalcase 1.9282 ms/op 1.7096 ms/op 1.13
altair processAttestation - 250000 vs - 7PWei worstcase 3.3865 ms/op 2.4688 ms/op 1.37
altair processAttestation - setStatus - 1/6 committees join 97.373 us/op 84.429 us/op 1.15
altair processAttestation - setStatus - 1/3 committees join 196.65 us/op 177.25 us/op 1.11
altair processAttestation - setStatus - 1/2 committees join 272.23 us/op 242.19 us/op 1.12
altair processAttestation - setStatus - 2/3 committees join 354.17 us/op 315.36 us/op 1.12
altair processAttestation - setStatus - 4/5 committees join 604.01 us/op 452.38 us/op 1.34
altair processAttestation - setStatus - 100% committees join 623.41 us/op 550.84 us/op 1.13
altair processBlock - 250000 vs - 7PWei normalcase 5.7684 ms/op 5.0395 ms/op 1.14
altair processBlock - 250000 vs - 7PWei normalcase hashState 31.469 ms/op 23.134 ms/op 1.36
altair processBlock - 250000 vs - 7PWei worstcase 40.061 ms/op 36.745 ms/op 1.09
altair processBlock - 250000 vs - 7PWei worstcase hashState 76.961 ms/op 67.177 ms/op 1.15
phase0 processBlock - 250000 vs - 7PWei normalcase 2.0404 ms/op 2.0840 ms/op 0.98
phase0 processBlock - 250000 vs - 7PWei worstcase 20.249 ms/op 19.762 ms/op 1.02
altair processEth1Data - 250000 vs - 7PWei normalcase 342.88 us/op 303.13 us/op 1.13
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 5.6210 us/op 5.4300 us/op 1.04
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 44.906 us/op 36.375 us/op 1.23
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 10.986 us/op 9.9140 us/op 1.11
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 6.3980 us/op 6.5740 us/op 0.97
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 114.94 us/op 133.61 us/op 0.86
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.1898 ms/op 1.1562 ms/op 1.03
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.4715 ms/op 1.6861 ms/op 0.87
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.5203 ms/op 1.5210 ms/op 1.00
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.7710 ms/op 3.7351 ms/op 1.01
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.5794 ms/op 1.6647 ms/op 0.95
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.7385 ms/op 3.8134 ms/op 0.98
Tree 40 250000 create 217.50 ms/op 219.74 ms/op 0.99
Tree 40 250000 get(125000) 150.71 ns/op 147.56 ns/op 1.02
Tree 40 250000 set(125000) 693.59 ns/op 651.68 ns/op 1.06
Tree 40 250000 toArray() 17.410 ms/op 19.753 ms/op 0.88
Tree 40 250000 iterate all - toArray() + loop 18.147 ms/op 19.487 ms/op 0.93
Tree 40 250000 iterate all - get(i) 58.456 ms/op 57.619 ms/op 1.01
Array 250000 create 3.2001 ms/op 3.1760 ms/op 1.01
Array 250000 clone - spread 1.4485 ms/op 1.4155 ms/op 1.02
Array 250000 get(125000) 0.43200 ns/op 0.41100 ns/op 1.05
Array 250000 set(125000) 0.44700 ns/op 0.43100 ns/op 1.04
Array 250000 iterate all - loop 103.97 us/op 109.01 us/op 0.95
phase0 afterProcessEpoch - 250000 vs - 7PWei 53.902 ms/op 49.595 ms/op 1.09
Array.fill - length 1000000 3.5816 ms/op 3.7321 ms/op 0.96
Array push - length 1000000 18.594 ms/op 16.952 ms/op 1.10
Array.get 0.28795 ns/op 0.28625 ns/op 1.01
Uint8Array.get 0.45600 ns/op 0.43968 ns/op 1.04
phase0 beforeProcessEpoch - 250000 vs - 7PWei 17.375 ms/op 18.016 ms/op 0.96
altair processEpoch - mainnet_e81889 274.62 ms/op 281.19 ms/op 0.98
mainnet_e81889 - altair beforeProcessEpoch 20.263 ms/op 18.522 ms/op 1.09
mainnet_e81889 - altair processJustificationAndFinalization 13.892 us/op 11.907 us/op 1.17
mainnet_e81889 - altair processInactivityUpdates 5.9522 ms/op 4.9451 ms/op 1.20
mainnet_e81889 - altair processRewardsAndPenalties 46.210 ms/op 43.924 ms/op 1.05
mainnet_e81889 - altair processRegistryUpdates 1.9990 us/op 2.0710 us/op 0.97
mainnet_e81889 - altair processSlashings 447.00 ns/op 343.00 ns/op 1.30
mainnet_e81889 - altair processEth1DataReset 477.00 ns/op 337.00 ns/op 1.42
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.0497 ms/op 1.9421 ms/op 1.06
mainnet_e81889 - altair processSlashingsReset 4.6330 us/op 2.7950 us/op 1.66
mainnet_e81889 - altair processRandaoMixesReset 4.4490 us/op 4.0880 us/op 1.09
mainnet_e81889 - altair processHistoricalRootsUpdate 615.00 ns/op 513.00 ns/op 1.20
mainnet_e81889 - altair processParticipationFlagUpdates 2.2760 us/op 1.7940 us/op 1.27
mainnet_e81889 - altair processSyncCommitteeUpdates 515.00 ns/op 425.00 ns/op 1.21
mainnet_e81889 - altair afterProcessEpoch 51.844 ms/op 49.781 ms/op 1.04
capella processEpoch - mainnet_e217614 1.0600 s/op 1.0299 s/op 1.03
mainnet_e217614 - capella beforeProcessEpoch 79.284 ms/op 66.352 ms/op 1.19
mainnet_e217614 - capella processJustificationAndFinalization 22.835 us/op 13.341 us/op 1.71
mainnet_e217614 - capella processInactivityUpdates 19.182 ms/op 16.276 ms/op 1.18
mainnet_e217614 - capella processRewardsAndPenalties 238.74 ms/op 219.30 ms/op 1.09
mainnet_e217614 - capella processRegistryUpdates 15.916 us/op 12.845 us/op 1.24
mainnet_e217614 - capella processSlashings 378.00 ns/op 343.00 ns/op 1.10
mainnet_e217614 - capella processEth1DataReset 347.00 ns/op 299.00 ns/op 1.16
mainnet_e217614 - capella processEffectiveBalanceUpdates 17.321 ms/op 12.087 ms/op 1.43
mainnet_e217614 - capella processSlashingsReset 6.3160 us/op 3.0860 us/op 2.05
mainnet_e217614 - capella processRandaoMixesReset 4.5840 us/op 5.9980 us/op 0.76
mainnet_e217614 - capella processHistoricalRootsUpdate 812.00 ns/op 514.00 ns/op 1.58
mainnet_e217614 - capella processParticipationFlagUpdates 2.0030 us/op 1.9340 us/op 1.04
mainnet_e217614 - capella afterProcessEpoch 128.90 ms/op 123.78 ms/op 1.04
phase0 processEpoch - mainnet_e58758 362.97 ms/op 341.27 ms/op 1.06
mainnet_e58758 - phase0 beforeProcessEpoch 86.914 ms/op 71.338 ms/op 1.22
mainnet_e58758 - phase0 processJustificationAndFinalization 22.709 us/op 16.979 us/op 1.34
mainnet_e58758 - phase0 processRewardsAndPenalties 29.704 ms/op 29.895 ms/op 0.99
mainnet_e58758 - phase0 processRegistryUpdates 9.3130 us/op 7.5900 us/op 1.23
mainnet_e58758 - phase0 processSlashings 378.00 ns/op 536.00 ns/op 0.71
mainnet_e58758 - phase0 processEth1DataReset 368.00 ns/op 334.00 ns/op 1.10
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.3929 ms/op 1.2458 ms/op 1.12
mainnet_e58758 - phase0 processSlashingsReset 2.5290 us/op 3.0060 us/op 0.84
mainnet_e58758 - phase0 processRandaoMixesReset 4.8160 us/op 3.9650 us/op 1.21
mainnet_e58758 - phase0 processHistoricalRootsUpdate 331.00 ns/op 667.00 ns/op 0.50
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.1280 us/op 3.0620 us/op 1.35
mainnet_e58758 - phase0 afterProcessEpoch 44.842 ms/op 42.256 ms/op 1.06
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.9330 ms/op 1.4118 ms/op 1.37
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.9779 ms/op 2.2630 ms/op 1.32
altair processInactivityUpdates - 250000 normalcase 16.754 ms/op 14.462 ms/op 1.16
altair processInactivityUpdates - 250000 worstcase 19.148 ms/op 14.943 ms/op 1.28
phase0 processRegistryUpdates - 250000 normalcase 9.7070 us/op 7.1560 us/op 1.36
phase0 processRegistryUpdates - 250000 badcase_full_deposits 307.52 us/op 264.65 us/op 1.16
phase0 processRegistryUpdates - 250000 worstcase 0.5 126.13 ms/op 108.04 ms/op 1.17
altair processRewardsAndPenalties - 250000 normalcase 33.093 ms/op 35.135 ms/op 0.94
altair processRewardsAndPenalties - 250000 worstcase 35.152 ms/op 36.173 ms/op 0.97
phase0 getAttestationDeltas - 250000 normalcase 10.761 ms/op 7.8579 ms/op 1.37
phase0 getAttestationDeltas - 250000 worstcase 8.5325 ms/op 7.6637 ms/op 1.11
phase0 processSlashings - 250000 worstcase 127.93 us/op 90.050 us/op 1.42
altair processSyncCommitteeUpdates - 250000 139.78 ms/op 123.32 ms/op 1.13
BeaconState.hashTreeRoot - No change 308.00 ns/op 263.00 ns/op 1.17
BeaconState.hashTreeRoot - 1 full validator 115.99 us/op 85.715 us/op 1.35
BeaconState.hashTreeRoot - 32 full validator 1.0776 ms/op 850.48 us/op 1.27
BeaconState.hashTreeRoot - 512 full validator 10.126 ms/op 8.7907 ms/op 1.15
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 125.87 us/op 103.14 us/op 1.22
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.8189 ms/op 1.3774 ms/op 1.32
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 21.922 ms/op 19.136 ms/op 1.15
BeaconState.hashTreeRoot - 1 balances 105.59 us/op 89.722 us/op 1.18
BeaconState.hashTreeRoot - 32 balances 940.73 us/op 1.1251 ms/op 0.84
BeaconState.hashTreeRoot - 512 balances 7.8435 ms/op 8.9250 ms/op 0.88
BeaconState.hashTreeRoot - 250000 balances 170.54 ms/op 188.50 ms/op 0.90
aggregationBits - 2048 els - zipIndexesInBitList 27.018 us/op 23.816 us/op 1.13
byteArrayEquals 32 55.617 ns/op 54.093 ns/op 1.03
Buffer.compare 32 17.795 ns/op 17.372 ns/op 1.02
byteArrayEquals 1024 1.6901 us/op 1.6014 us/op 1.06
Buffer.compare 1024 25.864 ns/op 24.933 ns/op 1.04
byteArrayEquals 16384 26.785 us/op 25.440 us/op 1.05
Buffer.compare 16384 218.60 ns/op 201.61 ns/op 1.08
byteArrayEquals 123687377 199.00 ms/op 188.64 ms/op 1.05
Buffer.compare 123687377 9.9147 ms/op 6.4375 ms/op 1.54
byteArrayEquals 32 - diff last byte 55.635 ns/op 51.950 ns/op 1.07
Buffer.compare 32 - diff last byte 18.607 ns/op 16.812 ns/op 1.11
byteArrayEquals 1024 - diff last byte 1.6828 us/op 1.5791 us/op 1.07
Buffer.compare 1024 - diff last byte 28.085 ns/op 24.933 ns/op 1.13
byteArrayEquals 16384 - diff last byte 26.721 us/op 25.047 us/op 1.07
Buffer.compare 16384 - diff last byte 222.28 ns/op 196.50 ns/op 1.13
byteArrayEquals 123687377 - diff last byte 195.23 ms/op 191.32 ms/op 1.02
Buffer.compare 123687377 - diff last byte 9.9629 ms/op 6.3814 ms/op 1.56
byteArrayEquals 32 - random bytes 5.3600 ns/op 5.0070 ns/op 1.07
Buffer.compare 32 - random bytes 17.781 ns/op 16.687 ns/op 1.07
byteArrayEquals 1024 - random bytes 5.3710 ns/op 4.9570 ns/op 1.08
Buffer.compare 1024 - random bytes 18.084 ns/op 16.648 ns/op 1.09
byteArrayEquals 16384 - random bytes 5.4120 ns/op 4.9520 ns/op 1.09
Buffer.compare 16384 - random bytes 20.268 ns/op 16.579 ns/op 1.22
byteArrayEquals 123687377 - random bytes 6.6800 ns/op 6.4700 ns/op 1.03
Buffer.compare 123687377 - random bytes 19.840 ns/op 17.900 ns/op 1.11
regular array get 100000 times 43.986 us/op 42.557 us/op 1.03
wrappedArray get 100000 times 37.120 us/op 31.803 us/op 1.17
arrayWithProxy get 100000 times 13.838 ms/op 12.913 ms/op 1.07
ssz.Root.equals 47.970 ns/op 43.906 ns/op 1.09
byteArrayEquals 47.308 ns/op 43.345 ns/op 1.09
Buffer.compare 11.019 ns/op 9.9030 ns/op 1.11
processSlot - 1 slots 19.252 us/op 16.893 us/op 1.14
processSlot - 32 slots 3.6163 ms/op 2.7027 ms/op 1.34
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 39.173 ms/op 37.971 ms/op 1.03
getCommitteeAssignments - req 1 vs - 250000 vc 2.3918 ms/op 2.0937 ms/op 1.14
getCommitteeAssignments - req 100 vs - 250000 vc 4.4001 ms/op 4.0695 ms/op 1.08
getCommitteeAssignments - req 1000 vs - 250000 vc 4.6547 ms/op 4.3238 ms/op 1.08
findModifiedValidators - 10000 modified validators 327.14 ms/op 242.12 ms/op 1.35
findModifiedValidators - 1000 modified validators 211.50 ms/op 166.13 ms/op 1.27
findModifiedValidators - 100 modified validators 199.76 ms/op 153.24 ms/op 1.30
findModifiedValidators - 10 modified validators 247.14 ms/op 143.93 ms/op 1.72
findModifiedValidators - 1 modified validators 262.68 ms/op 136.63 ms/op 1.92
findModifiedValidators - no difference 241.25 ms/op 162.18 ms/op 1.49
compare ViewDUs 4.4108 s/op 2.9804 s/op 1.48
compare each validator Uint8Array 2.0287 s/op 1.2884 s/op 1.57
compare ViewDU to Uint8Array 1.6501 s/op 1.0090 s/op 1.64
migrate state 1000000 validators, 24 modified, 0 new 1.0307 s/op 690.72 ms/op 1.49
migrate state 1000000 validators, 1700 modified, 1000 new 1.2138 s/op 987.95 ms/op 1.23
migrate state 1000000 validators, 3400 modified, 2000 new 1.5371 s/op 1.1372 s/op 1.35
migrate state 1500000 validators, 24 modified, 0 new 934.13 ms/op 733.34 ms/op 1.27
migrate state 1500000 validators, 1700 modified, 1000 new 1.1144 s/op 935.51 ms/op 1.19
migrate state 1500000 validators, 3400 modified, 2000 new 1.3243 s/op 1.1447 s/op 1.16
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.7800 ns/op 4.3600 ns/op 1.10
state getBlockRootAtSlot - 250000 vs - 7PWei 773.01 ns/op 786.80 ns/op 0.98
computeProposers - vc 250000 6.8711 ms/op 6.6792 ms/op 1.03
computeEpochShuffling - vc 250000 43.316 ms/op 41.092 ms/op 1.05
getNextSyncCommittee - vc 250000 133.78 ms/op 116.35 ms/op 1.15
computeSigningRoot for AttestationData 20.233 us/op 22.367 us/op 0.90
hash AttestationData serialized data then Buffer.toString(base64) 1.6496 us/op 1.4857 us/op 1.11
toHexString serialized data 953.11 ns/op 842.24 ns/op 1.13
Buffer.toString(base64) 205.92 ns/op 174.58 ns/op 1.18
nodejs block root to RootHex using toHex 180.69 ns/op 144.46 ns/op 1.25
nodejs block root to RootHex using toRootHex 106.97 ns/op 93.938 ns/op 1.14
browser block root to RootHex using the deprecated toHexString 317.25 ns/op 223.36 ns/op 1.42
browser block root to RootHex using toHex 224.90 ns/op 175.80 ns/op 1.28
browser block root to RootHex using toRootHex 175.82 ns/op 155.00 ns/op 1.13

by benchmarkbot/action

@nflaig nflaig added this to the v1.23.0 milestone Oct 25, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.21%. Comparing base (6de0736) to head (69ff639).
Report is 1 commits behind head on unstable.

Additional details and impacted files 
@@            Coverage Diff            @@
##           unstable    #7198   +/-   ##
=========================================
  Coverage     49.21%   49.21%           
=========================================
  Files           598      598           
  Lines         39794    39794           
  Branches       2090     2096    +6     
=========================================
+ Hits          19584    19585    +1     
+ Misses        20170    20169    -1     
  Partials         40       40

@ensi321 ensi321 merged commit bfa7a39 into unstable Oct 25, 2024
21 checks passed
@ensi321 ensi321 deleted the nflaig/remove-warning-log branch October 25, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ensi321 ensi321 ensi321 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nflaig @ensi321