Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use @types/react v18 consistently #332

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ jobs:
with:
cache: yarn
node-version: 18
- run: corepack enable
- run: yarn --immutable && yarn build
- run: yarn && yarn build

- name: Run benchmarks
run: yarn benchmark
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/cd-manual.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: CloudFlare Pages Deploy
on:
on:
workflow_dispatch:

jobs:
Expand All @@ -14,9 +14,8 @@ jobs:
with:
cache: yarn
node-version: '16'
- run: corepack enable
- name: Bootstrap
run: yarn --immutable
run: yarn
- name: Build
run: yarn build
- name: Publish to Cloudflare Pages
Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,20 +25,19 @@ jobs:
release-type: node
monorepo-tags: true
changelog-types: '[{"type":"feat","section":"Features","hidden":false},{"type":"fix","section":"Bug Fixes","hidden":false},{"type":"chore","section":"Miscellaneous","hidden":true}]'

- uses: actions/checkout@v3
if: ${{ steps.release.outputs.releases_created }}

- uses: actions/setup-node@v3
with:
cache: 'yarn'
node-version: 16
registry-url: 'https://registry.npmjs.org'
if: ${{ steps.release.outputs.releases_created }}

- run: corepack enable

- run: yarn install --immutable

- run: yarn install
if: ${{ steps.release.outputs.releases_created }}

- run: git config user.email $(git --no-pager show -s --format='%ae' HEAD)
Expand All @@ -54,7 +53,7 @@ jobs:
if: ${{ steps.release.outputs.releases_created }}
run: |
echo npmAuthToken: "$NODE_AUTH_TOKEN" >> ./.yarnrc.yml

- run: yarn workspaces foreach -v --exclude root --exclude simpleserialize.com --no-private npm publish --tolerate-republish --access public
if: ${{ steps.release.outputs.releases_created }}

Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,8 @@ jobs:
with:
node-version: ${{matrix.node}}
cache: yarn
- run: corepack enable
- name: Bootstrap
run: yarn --immutable
run: yarn
- name: Build
run: yarn build
- name: Check types
Expand Down
4 changes: 2 additions & 2 deletions packages/simpleserialize.com/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@
"@types/bn.js": "^5.1.0",
"@types/deep-equal": "^1.0.1",
"@types/file-saver": "^2.0.2",
"@types/react": "^17.0.13",
"@types/react": "^18.2.21",
"@types/react-alert": "^5.2.1",
"@types/react-dom": "^17.0.8",
"@types/react-dom": "^18.2.7",
"@types/react-loading-overlay": "^1.0.0",
"buffer": "^6.0.3",
"cross-env": "^7.0.3",
Expand Down
3 changes: 1 addition & 2 deletions simpleserialize.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ COPY package.json yarn.lock .yarnrc.yml ./
COPY packages/simpleserialize.com/package.json packages/simpleserialize.com/yarn.lock packages/simpleserialize.com/


RUN corepack enable
RUN yarn install --immutable
RUN yarn install

COPY . .
RUN npm rebuild node-sass
Expand Down
Loading