Try to recover from bad plugins unregistering PvPManager teams

ChanceSD · May 30, 2020 · 936761c · 936761c
1 parent a8aa07d
commit 936761c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/PvPManager/src/main/java/me/NoChance/PvPManager/Player/TeamProfile.java b/PvPManager/src/main/java/me/NoChance/PvPManager/Player/TeamProfile.java
@@ -25,7 +25,7 @@ public TeamProfile(final PvPlayer p) {
 		setupTeams();
 		final Team team = scoreboard.getEntryTeam(pvPlayer.getName());
 		// player got stuck in this team somehow (server crash?)
-		if (team != null && team.getPrefix().equals(ChatColor.translateAlternateColorCodes('&', Settings.getNameTagColor()))) {
+		if (team != null && team.getScoreboard() != null && team.getPrefix().equals(ChatColor.translateAlternateColorCodes('&', Settings.getNameTagColor()))) {
 			team.removeEntry(pvPlayer.getName());
 		}
 	}
@@ -78,7 +78,14 @@ public final void setInCombat() {
 		if (team != null && !team.equals(inCombat)) {
 			previousTeam = team;
 		}
-		inCombat.addEntry(pvPlayer.getName());
+		try {
+			inCombat.addEntry(pvPlayer.getName());
+		} catch (final IllegalStateException e) {
+			setupTeams();
+			inCombat.addEntry(pvPlayer.getName());
+			Log.info("Failed to add player to combat team");
+			Log.info("This warning can be ignored but if it happens often it means one of your plugins is removing PvPManager teams and causing a conflict");
+		}
 	}
 
 	public final void restoreTeam() {

diff --git a/PvPManager/src/main/java/me/NoChance/PvPManager/PvPlayer.java b/PvPManager/src/main/java/me/NoChance/PvPManager/PvPlayer.java
@@ -48,7 +48,7 @@ public PvPlayer(final Player player, final PvPManager plugin) {
 				Settings.setUseNameTag(false);
 				Settings.setToggleNametagsEnabled(false);
 				this.teamProfile = null;
-				Log.severe("Colored nametags disabled. You need to update your Spigot version.");
+				Log.warning("Colored nametags disabled. You need to update your Spigot version.");
 			}
 		}
 	}