Skip to content

Support Vue.js 3 using vue-demi #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions demo/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import Vue from 'vue'
import App from './Demo'

import Editor from '../src'

Vue.use(Editor)


Expand Down
14,067 changes: 6,317 additions & 7,750 deletions package-lock.json

Large diffs are not rendered by default.

58 changes: 32 additions & 26 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
"vue.js",
"vue-editor",
"vue-composition-api",
"vue3"
"vue3",
"vue-demi"
],
"repository": {
"type": "git",
Expand All @@ -17,7 +18,7 @@
"bugs": {
"url": "https://github.com/changjoo-park/vue-editor-js/issues"
},
"version": "2.0.2",
"version": "2.1.5",
"scripts": {
"serve": "vue-cli-service serve",
"build": "vue-cli-service build",
Expand All @@ -36,36 +37,41 @@
"src"
],
"dependencies": {
"@editorjs/editorjs": "^2.18.0",
"@vue/composition-api": "^0.5.0"
"@editorjs/editorjs": "^2.19.1",
"vue-demi": "latest",
"@vue/composition-api": "latest"
},
"peerDependencies": {
"@vue/composition-api": "^1.0.0-beta.1",
"vue": "^2.0.0 || >=3.0.0-rc.0"
},
"devDependencies": {
"@editorjs/warning": "^1.1.1",
"@editorjs/checklist": "^1.1.0",
"@editorjs/code": "^2.5.0",
"@editorjs/delimiter": "^1.1.0",
"@editorjs/embed": "^2.3.1",
"@editorjs/header": "^2.4.1",
"@editorjs/image": "^2.4.1",
"@editorjs/warning": "^1.2.0",
"@editorjs/checklist": "^1.3.0",
"@editorjs/code": "^2.6.0",
"@editorjs/delimiter": "^1.2.0",
"@editorjs/embed": "^2.4.0",
"@editorjs/header": "^2.6.1",
"@editorjs/image": "^2.6.0",
"@editorjs/inline-code": "^1.3.1",
"@editorjs/link": "^2.2.0",
"@editorjs/list": "^1.4.0",
"@editorjs/link": "^2.3.1",
"@editorjs/list": "^1.6.2",
"@editorjs/marker": "^1.2.2",
"@editorjs/paragraph": "^2.6.1",
"@editorjs/personality": "^2.0.1",
"@editorjs/quote": "^2.3.0",
"@editorjs/raw": "^2.1.2",
"@editorjs/simple-image": "^1.3.3",
"@editorjs/table": "^1.2.2",
"@vue/cli-plugin-babel": "^4.4.1",
"@vue/cli-plugin-eslint": "^4.4.1",
"@vue/cli-service": "^4.4.1",
"@editorjs/paragraph": "^2.8.0",
"@editorjs/personality": "^2.0.2",
"@editorjs/quote": "^2.4.0",
"@editorjs/raw": "^2.3.0",
"@editorjs/simple-image": "^1.4.0",
"@editorjs/table": "^1.3.0",
"@vue/cli-plugin-babel": "^4.5.11",
"@vue/cli-plugin-eslint": "^4.5.11",
"@vue/cli-service": "^4.5.11",
"babel-eslint": "^10.1.0",
"eslint": "^7.1.0",
"eslint-plugin-vue": "^6.2.2",
"vue": "^2.6.11",
"eslint": "^7.20.0",
"eslint-plugin-vue": "^7.6.0",
"vue": "^2.6.12",
"vue-cli-plugin-p11n": "^0.4.0",
"vue-template-compiler": "^2.6.11"
"vue-template-compiler": "^2.6.12"
},
"jsdelivr": "dist/vue-editor-js.umd.min.js",
"sideeffects": false
Expand Down
56 changes: 0 additions & 56 deletions src/Editor.vue

This file was deleted.

81 changes: 56 additions & 25 deletions src/index.js
Original file line number Diff line number Diff line change
@@ -1,31 +1,62 @@
const version = '__VERSION__'
import VueCompositionApi from '@vue/composition-api';
import EditorComponent from './Editor.vue'
import { reactive, defineComponent, onMounted, h } from "vue-demi";
import EditorJS from "@editorjs/editorjs";

export function install(Vue) {
if (install.installed) return;
install.installed = true;
Vue.use(VueCompositionApi)
Vue.component('Editor', EditorComponent)
}
export const Editor = defineComponent({
props: {
holder: {
type: String,
default: () => "vue-editor-js",
require: true,
},
config: {
type: Object,
default: () => ({}),
require: true,
},
initialized: {
type: Function,
default: () => {},
},
},
setup: (props) => {
const state = reactive({ editor: null });

const plugin = {
install,
version
}
function initEditor(props) {
destroyEditor();
state.editor = new EditorJS({
holder: props.holder || "vue-editor-js",
...props.config,
});
props.initialized(state.editor);
}

export const Editor = EditorComponent
function destroyEditor() {
if (state.editor) {
state.editor.destroy();
state.editor = null;
}
}

let GlobalVue = null
onMounted(() => {
console.log('on mounted')
initEditor(props)
});

if (typeof window !== 'undefined') {
GlobalVue = window.Vue
} else if (typeof global !== 'undefined') {
GlobalVue = global.Vue
}
return { props, state };
},
render(props) {
console.log('render')
return h(
'div',
{
id: props.holder
},
)
}
});

if (GlobalVue) {
GlobalVue.use(plugin)
}

export default plugin
export default {
install (Vue) {
Vue.component('Editor', Editor)
}
}
16 changes: 0 additions & 16 deletions src/plugin.js

This file was deleted.