Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update elastic search version #117

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Update elastic search version #117

merged 1 commit into from
Mar 28, 2024

Conversation

jacomago
Copy link
Contributor

No description provided.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

8 New issues
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code

See analysis details on SonarCloud

georgweiss
georgweiss approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@georgweiss georgweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any significant API changes spotted between 8.2.0 and 8.11.2?

@jacomago
Copy link
Contributor Author

Any significant API changes spotted between 8.2.0 and 8.11.2?

Only needing to use the FieldValue in querys.

ChannelFinderService/src/main/java/org/phoebus/channelfinder/ChannelRepository.java

Line 427 in c771291

builtQuery.searchAfter.ifPresent(s -> searchBuilder.searchAfter(FieldValue.of(s)));

@jacomago jacomago merged commit dd5d15f into ChannelFinder:master Mar 28, 2024
5 checks passed
@jacomago jacomago deleted the upgrade-elastic branch April 24, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgweiss georgweiss georgweiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacomago @georgweiss