Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable listening on ipv6 in the docker compose files. #135

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

jacomago
Copy link
Contributor

@jacomago jacomago commented Apr 11, 2024

Should reduce the erroneous logs from the pvAccess server in docker tests.

See https://github.com/ControlSystemStudio/phoebus/blob/5a69830bd5b4be7a23a1359dcb49a62de61049cb/core/pva/src/main/java/org/epics/pva/PVASettings.java#L130 for details of EPICS_PVAS_INTF_ADDR_LIST

@jacomago
Copy link
Contributor Author

@thelarsjohansson This one might fix the test failure in #122

Copy link
Contributor

@tynanford tynanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to this PR but is there a reason to expose elasticsearch port 9200 in the main docker-compose.yml? I think it's better to keep that only in the internal docker network and only expose the CF API

@jacomago
Copy link
Contributor Author

unrelated to this PR but is there a reason to expose elasticsearch port 9200 in the main docker-compose.yml? I think it's better to keep that only in the internal docker network and only expose the CF API

I think it was only kept for debugging purposes. I'll remove it in another pull request.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jacomago jacomago merged commit d5f18e4 into ChannelFinder:master Apr 12, 2024
5 checks passed
@jacomago jacomago deleted the no-ipv6-listne branch April 12, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants