Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helm chart with sensible defaults #164

Closed
wants to merge 7 commits into from

Conversation

stan-dot
Copy link

@stan-dot stan-dot commented Oct 8, 2024

No description provided.

@jacomago
Copy link
Contributor

jacomago commented Oct 9, 2024

Does this really need to be in the main ChannelFinder repository? Couldn't it be in another one?

@stan-dot
Copy link
Author

stan-dot commented Oct 9, 2024

you are right this need not be in this repo.
still the values can be overriden for a custom deployment.

Having the helm chart in the ChannelFinder repo would help potential users looking to deploy it - they would have one step less to worry about.

There is a precedent for that at DLS
https://github.com/DiamondLightSource/blueapi/tree/main/helm/blueapi

@jacomago
Copy link
Contributor

jacomago commented Oct 9, 2024

Could have another repo inside ChannelFinder organisation, then a link to the repo inside this one. Seems a bit overkill to have to maintain: dockerfile, docker-compose file, helm chart and kubernetes configuration inside of the repository which is just for the application really.
Having it outside also means you could add recceiver into the kubernetes configuration, as usually these are heavily linked.

@stan-dot
Copy link
Author

stan-dot commented Oct 9, 2024

that would be a good setup. If you make that repo I'll close this PR and make a new PR to that repo

@jacomago
Copy link
Contributor

jacomago commented Oct 9, 2024

https://github.com/ChannelFinder/kubernetes

@stan-dot
Copy link
Author

stan-dot commented Oct 9, 2024

git has issues when the repo is empty and I can't make a fork

please add a barebones readme
https://github.com/channelfinder/kubernetes

Copy link

@jacomago
Copy link
Contributor

@stan-dot I added a readme to the project.

@stan-dot
Copy link
Author

thanks @jacomago

the PR is here ChannelFinder/kubernetes#1

it doesn't deploy correctly for now because the image is not pushed to the registry - I am working on it

@stan-dot
Copy link
Author

arguably the Dockerfile is needed for that, and it would live in this repo - and this PR already has two dockerfiles - https://github.com/ChannelFinder/ChannelFinderService/pull/164/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557

I'd be happy to put that in a separate PR ' make Dockerfile do build', not sure how it would play with the repo vision

@stan-dot
Copy link
Author

issue now tracked here (ChannelFinder/kubernetes#1) , closing this PR

@stan-dot stan-dot closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants