-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a helm chart with sensible defaults #164
Conversation
Does this really need to be in the main ChannelFinder repository? Couldn't it be in another one? |
you are right this need not be in this repo. Having the helm chart in the ChannelFinder repo would help potential users looking to deploy it - they would have one step less to worry about. There is a precedent for that at DLS |
Could have another repo inside ChannelFinder organisation, then a link to the repo inside this one. Seems a bit overkill to have to maintain: dockerfile, docker-compose file, helm chart and kubernetes configuration inside of the repository which is just for the application really. |
that would be a good setup. If you make that repo I'll close this PR and make a new PR to that repo |
git has issues when the repo is empty and I can't make a fork please add a barebones readme |
Quality Gate passedIssues Measures |
@stan-dot I added a readme to the project. |
thanks @jacomago the PR is here ChannelFinder/kubernetes#1 it doesn't deploy correctly for now because the image is not pushed to the registry - I am working on it |
arguably the Dockerfile is needed for that, and it would live in this repo - and this PR already has two dockerfiles - https://github.com/ChannelFinder/ChannelFinderService/pull/164/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557 I'd be happy to put that in a separate PR ' make Dockerfile do build', not sure how it would play with the repo vision |
issue now tracked here (ChannelFinder/kubernetes#1) , closing this PR |
No description provided.