Skip to content

Conversation

@tynanford
Copy link
Contributor

Alternate version of #109

There is a nice side-effect with the python ConfigParser.getboolean function where it is case-insensitive and recognizes Boolean values from yes/no, on/off, true/false and 1/0 https://docs.python.org/3/library/configparser.html#supported-datatypes

So older setting files like this would still work as before:

alias = off
recordType = on

…to be boolean

Note: Users should update their configuration files to use 'True'/'False' for these settings but the ConfigParser getboolean handles 'off', '0', and 'no' as False so this should be backwards compatible with existing cf conf files
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@jacomago
Copy link
Contributor

Looks way better.

@simon-ess
Copy link
Contributor

I agree with @jacomago

@simon-ess simon-ess self-requested a review June 19, 2025 13:58
@tynanford tynanford merged commit ddab4f3 into ChannelFinder:master Jun 19, 2025
19 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants