Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate cargo deny in the CI / CD pipeline #192

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Integrate cargo deny in the CI / CD pipeline #192

merged 1 commit into from
Sep 18, 2024

Conversation

francois141
Copy link
Collaborator

@francois141 francois141 commented Sep 17, 2024 •
edited
Loading

No description provided.

@francois141 francois141 linked an issue Sep 17, 2024 that may be closed by this pull request
Lint dependencies with cargo deny #56
Open
3 tasks
@francois141 francois141 force-pushed the 56-lint-dependencies-with-cargo-deny branch 2 times, most recently from 9c92970 to 226d1f3 Compare September 17, 2024 14:57
@francois141 francois141 changed the title Integrate cargo vet in the CI / CD pipeline Integrate cargo deny in the CI / CD pipeline Sep 17, 2024
@francois141 francois141 force-pushed the 56-lint-dependencies-with-cargo-deny branch 2 times, most recently from 57b3cf2 to 0350c0a Compare September 17, 2024 15:06
@francois141 francois141 added the Test Testing or CI setup label Sep 17, 2024
@francois141 francois141 force-pushed the 56-lint-dependencies-with-cargo-deny branch from 73464b6 to 0fc09db Compare September 17, 2024 15:14
@CharlyCst CharlyCst force-pushed the 56-lint-dependencies-with-cargo-deny branch from 0fc09db to 39ec9de Compare September 18, 2024 08:30
@CharlyCst
Copy link
Owner

I rebased the PR, but turns out installing Cargo Deny in the CI adds 3 more minutes, which is quite a lot...
There seems to be github action that we could use: https://github.com/EmbarkStudios/cargo-deny-action
But then we need to remove the cargo deny installation from just install, which will break local tests...

I think we will need a smarter test system in the future (probably as part of the runner), but in the meantime I will simply merge the PR without the bits in the justfile, which means that Cargo Deny will need to be run manually. Its good that we fixed the existing issues though :)

@francois141 @CharlyCst
Integrate cargo deny in the CI / CD pipeline
ba92730 
Cargo deny is a Rust tool used to enforce and manage linting rules and policy compliance in a project. It allows developers to configure and enforce rules related to code quality, dependency management, and security, ensuring that code adheres to specific standards.
@CharlyCst CharlyCst force-pushed the 56-lint-dependencies-with-cargo-deny branch from 39ec9de to ba92730 Compare September 18, 2024 08:42
@CharlyCst CharlyCst merged commit 0e5cc95 into main Sep 18, 2024
1 check passed
@CharlyCst CharlyCst deleted the 56-lint-dependencies-with-cargo-deny branch September 18, 2024 08:46
@CharlyCst CharlyCst mentioned this pull request Sep 18, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlyCst CharlyCst Awaiting requested review from CharlyCst

Assignees
No one assigned
Labels
Test Testing or CI setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint dependencies with cargo deny
2 participants
@francois141 @CharlyCst