Remove Ecall and Ebreak from Instr #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlyCst
force-pushed
the
remove-ecal-ebreak-decoder
branch
from
7443b45 to
6e70cea
Compare
CharlyCst
reviewed
Jan 20, 2025
francois141
force-pushed
the
remove-ecal-ebreak-decoder
branch
from
6e70cea to
17df031
Compare
|
Yes, I fixed this in another branch. I rebased the code with a decoder that should work now. |
The ECALL and EBREAK instructions have distinct mcause values and are not considered illegal instructions. Since they trigger different types of traps, they do not require decoding in our decoder for illegal instructions. As a result, we can safely remove them from the instruction decoder.
CharlyCst
force-pushed
the
remove-ecal-ebreak-decoder
branch
from
17df031 to
4a49aef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ECALL and EBREAK instructions have distinct mcause values and are not considered illegal instructions. Since they trigger different types of traps, they do not require decoding in our decoder for illegal instructions. As a result, we can safely remove them from the instruction decoder.