SailBugfix: Modifies only Mip in write Sip correctly #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the implementation allows excessive modification of bits in the `Mip` register without verifying whether the corresponding interrupts are delegated via `Mideleg`. This commit addresses the issue by ensuring proper delegation checks, aligning the behavior with the expected privilege separation.
CharlyCst
force-pushed
the
sailbugfix-sip-write
branch
from
e6fcf53 to
f159730
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the implementation allows excessive modification of bits in the
Mipregister without verifying whether the corresponding interrupts are delegated viaMideleg. This commit addresses the issue by ensuring proper delegation checks, aligning the behavior with the expected privilege separation.