Introduce formal verification for compressed loads and stores #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francois141
force-pushed
the
sail-compressed-load-store
branch
from
ff3ce13 to
5e29af8
Compare
CharlyCst
reviewed
Feb 11, 2025
There was a problem hiding this comment.
Overall looks good to me, there is just one nit regarding the code organization: I am not a fan of creating two new crates when we already have one for the decoder. Could we create a single decoder crate instead, and have three modules there for the different sub-parts of the decoder? This also raise the question of how to name the "main" decoder, does it only decode CSRs? If yes is it the "CSR" or "privileged" decoder?
francois141
force-pushed
the
sail-compressed-load-store
branch
2 times, most recently
from
38bef46 to
80eb22d
Compare
|
Changes done |
francois141
force-pushed
the
sail-compressed-load-store
branch
from
80eb22d to
d98535b
Compare
This commit adds two new symbolic test for verifying the decoding process of the compressed loads and stores. The process found one bug which was fixed in a recent previous commit.
Currently unsigned loads with 8 bytes precisions are not decoded and correspond to an unknown instruction in Miralis. This commit decodes them.
This commit adds two new symbolic test for verifying the decoding process of the loads and stores. The process found one bug which was fixed in a recent previous commit.
CharlyCst
force-pushed
the
sail-compressed-load-store
branch
from
d98535b to
71df188
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two new symbolic test for verifying the compressed loads and stores. The process found one bug which was fixed in a recent previous commit.