Missing csr ops #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Register 32 does not exist, replaced it by 31
3 CSR registers to be used
CharlyCst
requested changes
Feb 22, 2024
There was a problem hiding this comment.
That looks great to me!
I will merge that one once the first PR has been rebased (see comments there).
One minor remark: its nice to have slightly more precise commit messages, this makes the projet easier to maintain in the long run. Here for instance you can name the three new CSR operations. But don't worry about that this time :)
|
Closing in favor of #9, which is just a rebase of this PR on top of the rebased main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the missing CSR operations and tested them with success