Skip to content

Conversation

@xeunnie
Copy link
Member

@xeunnie xeunnie commented Jun 13, 2025

💡 PR 제목

멘션 기능을 추가했지만 아직 테스트는 안해본 상태입니다!

✅ 요구사항

  • 요구사항 1
  • 요구사항 2

⭐ 시연

✅ 기능1

✅ 리뷰어가 알아야할 사항

✅ 체크리스트

  • 자신의 코드에 대한 리뷰를 진행했습니다
  • 실행 후 심각한 버그나 경고문이 없음을 확인했습니다
  • 이해하기 어려운 부분에 적절한 주석을 첨부했습니다
  • 요구사항 변경, 레이아웃 변경 등 변경사항을 문서에 반영했습니다

@xeunnie xeunnie added this to the Component milestone Jun 13, 2025
@xeunnie xeunnie requested review from Copilot and dbswl701 June 13, 2025 13:19
@xeunnie xeunnie self-assigned this Jun 13, 2025
@xeunnie xeunnie added component 컴포넌트 구현 feature 기능 구현 labels Jun 13, 2025
@netlify
Copy link

netlify bot commented Jun 13, 2025

Deploy Preview for chatflow-project failed.

Name Link
🔨 Latest commit 7f9c9dc
🔍 Latest deploy log https://app.netlify.com/projects/chatflow-project/deploys/684c26faa1495a0009964e11

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR appears to remove several existing API and authentication-related files as part of implementing the new mention functionality. The changes include removal of the axios instance configuration, API response types, authentication types, and authentication API functions.

  • Removed axiosInstance.ts, apiType.ts, auth types, and corresponding auth API functions.
  • Eliminated UserProfile types and profile API functions along with authentication endpoints.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/service/feature/common/axios/axiosInstance.ts Removed the axios instance configuration and error handling functions.
src/service/feature/common/axios/apiType.ts Removed the ApiResponse type used for API responses.
src/service/feature/auth/types/profile.ts Removed UserProfile type definitions and related member state types.
src/service/feature/auth/types/auth.ts Removed authentication type definitions (LoginRequest, etc.).
src/service/feature/auth/api/profileAPI.ts Removed the getProfile API implementation.
src/service/feature/auth/api/authAPI.ts Removed authentication API functions: login and register.
Comments suppressed due to low confidence (6)

src/service/feature/common/axios/axiosInstance.ts:1

  • The removal of the axiosInstance file can break modules depending on the HTTP client; ensure that a new configuration is provided or update the affected modules accordingly.
import axios, { AxiosInstance, AxiosError, AxiosResponse } from 'axios';

src/service/feature/common/axios/apiType.ts:1

  • Removal of the ApiResponse type may affect response handling across the codebase; confirm that consuming modules are updated to handle API responses properly.
export interface ApiResponse<T> {

src/service/feature/auth/types/profile.ts:1

  • The removal of the UserProfile interface and related types could result in type errors for modules that depend on them; verify that downstream updates or deprecations are in place.
export type MemberState = 'ONLINE' | 'OFFLINE' | 'IDLE' | 'DO_NOT_DISTURB';

src/service/feature/auth/types/auth.ts:1

  • Removing the auth types (LoginRequest, LoginResponse, etc.) is a breaking change; ensure that the authentication flows and their corresponding type imports are updated accordingly.
export interface LoginRequest {

src/service/feature/auth/api/profileAPI.ts:1

  • The removal of the getProfile API function might break features that rely on it; update or remove the calling code to align with the new mention functionality.
import createAxiosInstance from '@service/feature/common/axios/axiosInstance.ts';

src/service/feature/auth/api/authAPI.ts:1

  • The deletion of the login and register functions may disrupt authentication mechanisms; ensure that corresponding new implementations are provided or that dependent modules are updated accordingly.
import createAxiosInstance from '@service/feature/common/axios/axiosInstance.ts';

@xeunnie xeunnie merged commit fb3b898 into develop Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component 컴포넌트 구현 feature 기능 구현

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants