-
-
Notifications
You must be signed in to change notification settings - Fork 498
add Import/Export for Nicknames #6160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind this feature, but if the goal is to share nicknames between friends I'd prefer if this used something like your system clipboard instead.
So the export button would export the nickname json to your clipboard, and the import button would read that json blob from your clipboard
The label of the buttons should probably be updated to reflect that change as well. "Import from clipboard" and "Export to clipboard" if it fits.
If it doesn't fit where they are now, you can move it to below the nicknames instead.
I did not consider character limits, let me give it a think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Sorry for the delay! I think files are fine, however I think I'd like to be a bit forward-thinking with the import & export format. I think something like this would be good: {
"type": "nickname_export",
"version": "1",
"comment": "Exported from Version::instance().buildString() at CURRENT TIME",
"data": [
// the nicknames in the same format you were already using
]
} I'm not convinced of the place for the "exportNicknames" and "importNicknames" functions, so I might want to move those around a bit but that's easy to do as a last step. |
Hey we wanted to exchange nicknames among friends, so we came up with the idea of adding import and export buttons to the Nicknames view.
This is my first time with C++ code, so feedback is very welcome.
Tested on Ubuntu:



