Add support for JIRA API v3, including backward compatibility for com…#17
Add support for JIRA API v3, including backward compatibility for com…#17marko-p wants to merge 1 commit intoChavaillaz:masterfrom
Conversation
…ments and descriptions
| * @param version The API version (2 or 3) | ||
| * @return This client for method chaining | ||
| * @throws IllegalArgumentException if the version is not 2 or 3 | ||
| */ |
There was a problem hiding this comment.
I think you can remove this comment as the one in the method of the parent interface is more detailed and has the same purpose.
| * Base API path for JIRA REST API v2. | ||
| * This is the default API version for backward compatibility. | ||
| */ | ||
| public static final String BASE_API_V2 = "/rest/api/2/"; |
There was a problem hiding this comment.
As it's not used anywhere else, I would propose to have both URLs directly in the enum below instead of being defined as constants.
| * @param version The API version | ||
| * @return The base path for the specified version | ||
| */ | ||
| public static String getBaseApiPath(ApiVersion version) { |
There was a problem hiding this comment.
I didn't find where this method is called, possibly to remove if it's unused.
| /** | ||
| * Enumeration of supported JIRA REST API versions. | ||
| */ | ||
| public enum ApiVersion { |
There was a problem hiding this comment.
I would propose to have that enum separated in a dedicated file and not as inner enum.
| } | ||
|
|
||
| @Override | ||
| // ...existing code... |
There was a problem hiding this comment.
Keep the Override annotation here
| } | ||
|
|
||
| @Override | ||
| // ...existing code... |
There was a problem hiding this comment.
Keep the Override annotation here
| } | ||
|
|
||
| @Override | ||
| // ...existing code... |
There was a problem hiding this comment.
Keep the Override annotation here
| } | ||
|
|
||
| @Override | ||
| // ...existing code... |
There was a problem hiding this comment.
Keep the Override annotation here
| } | ||
|
|
||
| @Override | ||
| // ...existing code... |
There was a problem hiding this comment.
Keep the Override annotation here
| } | ||
|
|
||
| @Override | ||
| // ...existing code... |
There was a problem hiding this comment.
Keep the Override annotation here
| * @param urlPattern The URL pattern to append | ||
| * @return The complete URL | ||
| */ | ||
| protected String buildUrl(String urlPattern) { |
There was a problem hiding this comment.
I don't think this method and the similar one in other implementationsn are used.
2 participants
…ments and descriptions