Fix: Migrate to dedicated station count endpoints #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliangruber
requested changes
May 6, 2024
PatrickNercessian
force-pushed
the
fix-dedicated-platform-endpoints
branch
from
cf9be9c to
f4db89d
Compare
bajtos
requested changes
May 9, 2024
lib/request-helpers.js
Outdated
| * @param {import('./typings').Filter} args.filter | ||
| * @param {string} [args.asColumn] | ||
| */ | ||
| export const getDailyDistinctCountQuery = async ({ |
There was a problem hiding this comment.
Since this function executes the query instead of returning the query, I think it should not have Query in the name.
Suggested change
| export const getDailyDistinctCountQuery = async ({ | |
| export const getDailyDistinctCount = async ({ |
lib/request-helpers.js
Outdated
| * @param {import('./typings').Filter} args.filter | ||
| * @param {string} [args.asColumn] | ||
| */ | ||
| export const getMonthlyDistinctCountQuery = async ({ |
There was a problem hiding this comment.
Ditto.
Suggested change
| export const getMonthlyDistinctCountQuery = async ({ | |
| export const getMonthlyDistinctCount = async ({ |
bajtos
approved these changes
May 10, 2024
| await assertResponseStatus(res, 200) | ||
| const metrics = await res.json() | ||
| assert.deepStrictEqual(metrics, [ | ||
| { month: '2024-01-01', station_id_count: 3 }, |
There was a problem hiding this comment.
I have mixed feelings about the name station_id_count. I slightly prefer to use stations (we use participants in GET /participants/daily) or even count.
However, I also see how station_id_count is a very descriptive & accurate name, so I am fine to keep it.
There was a problem hiding this comment.
I like how precise it is, also it is a bit leaky (potentially exposes too many internals). I suggest we iterate on this at a later point, when we understand our system better
juliangruber
approved these changes
May 10, 2024
PatrickNercessian
added a commit
to PatrickNercessian/spark-stats
that referenced
this pull request
May 12, 2024
* Migrate to dedicated station count endpoints * Improved local helper function SQL security * Renamed request helper methods
PatrickNercessian
added a commit
to PatrickNercessian/spark-stats
that referenced
this pull request
May 12, 2024
* Migrate to dedicated station count endpoints * Improved local helper function SQL security * Renamed request helper methods
bajtos
added a commit
that referenced
this pull request
May 13, 2024
* Add honest_measurement_count platform stat * Switched to new column name for measurement count * Fix: Migrate to dedicated station count endpoints (#93) * Migrate to dedicated station count endpoints * Improved local helper function SQL security * Renamed request helper methods * Add honest_measurement_count platform stat --------- Co-authored-by: Miroslav Bajtoš <oss@bajtos.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roadmap Issue: CheckerNetwork/roadmap#97
Follow up to #71