fix(sarif): deduplicate CWE taxa entries to fix schema validation failure#7974
Open
cx-ori-bendet wants to merge 1 commit intomasterfrom
Open
fix(sarif): deduplicate CWE taxa entries to fix schema validation failure#7974cx-ori-bendet wants to merge 1 commit intomasterfrom
cx-ori-bendet wants to merge 1 commit intomasterfrom
Conversation
…lure Multiple queries sharing the same CWE ID (e.g. CWE-798) caused duplicate entries in the SARIF taxonomies taxa array. This caused schema validation errors and prevented SARIF upload to GitHub and other consumers. Add a seenCWEs map to ensure each CWE ID is appended to auxID only once before being passed to RebuildTaxonomies. Fixes #7588 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
bot
added
community
Contributor
|
KICS version: v2.1.18
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runs[0].taxonomies[1].taxaof the SARIF outputinstance.runs[0].taxonomies[1].taxa contains duplicate itemschema validation errors, blocking SARIF upload to GitHub and other consumersauxID []stringinPrintSarifReportaccumulated all CWE IDs without deduplication across queriesseenCWEsmap so each CWE ID is only appended toauxIDonce before being passed toRebuildTaxonomiesFixes #7588
Test plan
@Microsoft.KeyVault(...)references triggering CWE-798) and verify the SARIF output passes schema validation.sariffile to GitHub viagithub/codeql-action/upload-sarif— should succeed without duplicate taxa errorsgo test ./pkg/report/...to verify existing tests still passI submit this contribution under the Apache-2.0 license.
🤖 Generated with Claude Code