Skip to content

fix(terraform): fix inverted logic in Workload Host Port Not Specified query #7976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cx-ori-bendet wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(terraform): fix inverted logic in Workload Host Port Not Specified query #7976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions assets/queries/terraform/kubernetes/workload_host_port_not_specified/query.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ CxPolicy[result] {

path := checkPath(resource)

not common_lib.valid_key(path.port, "host_port")
common_lib.valid_key(path.port, "host_port")
result := {
"documentId": input.document[i].id,
"resourceType": x,
"resourceName": tf_lib.get_resource_name(resource, name),
"searchKey": sprintf("%s[%s].%s.port", [x, name, resource_prefix]),
"issueType": "IncorrectValue",
"keyExpectedValue": "Attribute 'host_port' should be defined and not null",
"keyActualValue": "Attribute 'host_port' is undefined or null",
"keyExpectedValue": "Attribute 'host_port' should not be defined",
"keyActualValue": "Attribute 'host_port' is defined",
}
}

Expand Down
1 change: 0 additions & 1 deletion assets/queries/terraform/kubernetes/workload_host_port_not_specified/test/negative1.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ resource "kubernetes_pod" "test" {

port {
container_port = 8080
host_port = 2
}

liveness_probe {
Expand Down
1 change: 0 additions & 1 deletion assets/queries/terraform/kubernetes/workload_host_port_not_specified/test/negative2.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ resource "kubernetes_deployment" "example" {
}
port {
container_port = 8080
host_port = 2
}

liveness_probe {
Expand Down
1 change: 1 addition & 0 deletions assets/queries/terraform/kubernetes/workload_host_port_not_specified/test/positive1.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ resource "kubernetes_pod" "test" {

port {
container_port = 8080
host_port = 2
}

liveness_probe {
Expand Down
1 change: 1 addition & 0 deletions assets/queries/terraform/kubernetes/workload_host_port_not_specified/test/positive2.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ resource "kubernetes_deployment" "example" {
}
port {
container_port = 8080
host_port = 2
}

liveness_probe {
Expand Down
Loading