add one interactive thread for improved spot support #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #140 +/- ##
==========================================
- Coverage 46.56% 41.60% -4.97%
==========================================
Files 3 3
Lines 1748 1745 -3
==========================================
- Hits 814 726 -88
- Misses 934 1019 +85 ☔ View full report in Codecov by Sentry. |
samtkaplan
force-pushed
the
spot
branch
5 times, most recently
from
8beb4b7 to
f753629
Compare
JayMcIrish173
approved these changes
Sep 11, 2023
jkwashbourne-oss
approved these changes
Oct 22, 2023
samtkaplan
force-pushed
the
spot
branch
4 times, most recently
from
46688e9 to
f8bd033
Compare
Add an interactive thread and a loop on that thread that checks for spot eviction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running with SPOT scale-sets, on each worker start a loop that watches for pre-empt (spot) events. Upon receiving an event, exit Julia. This work gets the mechanism put in place. Future PRs can work on adding the ability to run user-defined code before the exit.
update
This was super-ceded by #143 since we couldn't figure out how to get interactive threads working. But, this now works, but does require the user to explicitly run their parallel work-load in the default thread pool via the
Threads.@threadsmacro.