Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update commit message for the time being, switch over pendingci bot to alert in devrel, and make the unverified bot live. #46

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Update commit message for the time being, switch over pendingci bot to alert in devrel, and make the unverified bot live. #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20bc79e
Change message to include the website that provides more options for …
pmaslana Aug 5, 2024
76d2dce
Moving the check for pending CI bot to send mesasages to devrel and a…
pmaslana Aug 5, 2024
b90ca32
Add additional logging
pmaslana Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ jobs:
- name: label-prs
- name: notify-stale-prs
- name: notify-pending-prs
- name: notify-unsigned
steps:
- uses: actions/checkout@v4

Expand Down
4 changes: 2 additions & 2 deletions internal/github/checkUnsigned.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ func hasUnsignedCommits(ctx context.Context, githubClient *github.Client, pr *gi
// CheckAndComment checks for the specific comment from a specific account and posts a comment if it doesn't exist.
func CheckAndComment(ctx context.Context, client *github.Client, owner, repo string, prNumber int) error {
commentAuthor := "ChiaAutomation"
commentBody := "Your commits are not signed and our branch protection rules require signed commits. For more information on how to create signed commits, please visit this page: https://docs.chia.net/contribution/using-github/#setup-commit-signing. Please use the button towards the bottom of the page to close this pull request and open a new one with signed commits."
commentBody := "Your commits are not signed and our branch protection rules require signed commits. For more information on how to create signed commits, please visit this page: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification. Please use the button towards the bottom of the page to close this pull request and open a new one with signed commits."
comments, _, err := client.Issues.ListComments(ctx, owner, repo, prNumber, nil)
if err != nil {
return fmt.Errorf("error fetching comments: %v", err)
Expand All @@ -121,7 +121,7 @@ func CheckAndComment(ctx context.Context, client *github.Client, owner, repo str
comment := &github.IssueComment{
Body: github.String(commentBody),
}

slogs.Logr.Info("Creating comment for unsigned commits", "repo", repo, "PR", prNumber)
_, _, err = client.Issues.CreateComment(ctx, owner, repo, prNumber, comment)
if err != nil {
return fmt.Errorf("error creating comment: %v", err)
Expand Down
2 changes: 1 addition & 1 deletion k8s/notify-pending-prs.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ secretEnvironment:
GITHUB_BOT_DB_USER: "{{ DB_USER }}"
GITHUB_BOT_DB_PASS: "{{ DB_PASS }}"
GITHUB_BOT_DB_NAME: "github-bot"
KEYBASE_WEBHOOK_URL: "https://alert-receiver.chiaops.com/teambottesting"
KEYBASE_WEBHOOK_URL: "https://alert-receiver.chiaops.com/devrel"
WEBHOOK_AUTH_SECRET_TOKEN: "{{ WEBHOOK_AUTH_SECRET_TOKEN }}"

networkPolicy:
Expand Down