Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging for when commits are not verified #49

Merged
merged 2 commits into from
Aug 18, 2024
Merged

Add logging for when commits are not verified #49

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb1f000
Add logging for when commits are not verified
pmaslana Aug 18, 2024
6173a8f
Split out the nil and non-verified checks
pmaslana Aug 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions internal/github/checkUnsigned.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,12 @@ func hasUnsignedCommits(ctx context.Context, githubClient *github.Client, pr *gi
continue
}
verification := commit.Commit.Verification
if verification == nil || !*verification.Verified {
return true, nil
if verification == nil {
slogs.Logr.Info("Commit has no verification field", "commit_sha", commit.GetSHA(), "author", commit.Commit.Author.GetName(), "email", commit.Commit.Author.GetEmail())
return true, nil // Log and flag if no verification field
} else if !*verification.Verified {
slogs.Logr.Info("Commit is not verified", "commit_sha", commit.GetSHA(), "author", commit.Commit.Author.GetName(), "email", commit.Commit.Author.GetEmail(), "reason", verification.GetReason())
return true, nil // Log and flag if the commit is not verified
}
}
unsignedCancel() // Clean up the context at the end of the loop iteration
Expand Down
Loading