Feature/per username social platforms #119
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement three-tier configuration priority (per-username > per-platform > default) - Add dynamic secret loading for DISCORD_WEBHOOK_PLATFORM_USERNAME and DISCORD_ROLE_PLATFORM_USERNAME - Update all social platform post() signatures for consistency (username parameter) - Maintain 100% backward compatibility with existing single-streamer setups - Add Configuration Mode 4 documentation with examples - Create comprehensive testing guide for per-username configurations - Support use case: multiple streamers per platform, each with own Discord channel/role
- Implement per-username client/config management for all social platforms - Add dynamic credential loading with fallback to default accounts - Support different Bluesky accounts per streamer (BLUESKY_HANDLE_PLATFORM_USERNAME) - Support different Mastodon instances/accounts per streamer (MASTODON_API_BASE_URL_PLATFORM_USERNAME) - Support different Matrix rooms per streamer (MATRIX_ROOM_ID_PLATFORM_USERNAME) - Maintain 100% backward compatibility with single-account configurations - Create comprehensive per-username social platforms documentation - All platforms follow two-tier priority: per-username > default
…ature - Add per-username configuration to features list in main docs - Add quick reference examples for per-username setup - Add per-username note to Matrix platform documentation - Link to comprehensive per-username configuration guide
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Create constants.py with all secret environment variable name constants - Replace hardcoded strings in discord.py (lines 125, 126, 218, 219) - Replace hardcoded strings in matrix.py (lines 87, 100, 105, 115, 132, 133, 207, 251) - Use constants from stream_daemon.config.constants module - Maintain backward compatibility - no functional changes - Fixes security scanner warnings about hardcoded credentials
- Bluesky: Fixed 6 hardcoded secret env var names (lines 57-59, 95-97) - Mastodon: Fixed 9 hardcoded secret env var names (lines 57-59, 61-63, 65-67, 107-109, 111-113, 115-117) - Twitch: Fixed 6 hardcoded secret env var names (lines 30-36) - Kick: Fixed 6 hardcoded secret env var names (lines 30-36) - YouTube: Fixed 3 hardcoded secret env var names (lines 30-32) All platforms now import constants from stream_daemon.config.constants Per-username configs build dynamic secret env names from base constants Total: 30 hardcoded strings eliminated (Discord+Matrix: 12, now: 30 more)
- discord.py: Removed duplicate import block (lines 18-25 duplicated lines 5-16) * Kept 'import os' which was only in second block * Eliminated redundant imports: logging, re, time, typing, urlparse, requests, get_config, get_bool_config, get_secret - matrix.py: Simplified repetitive constant passing in authenticate() * Line 86-89: homeserver still uses explicit constants (first in function) * Lines 92, 110, 120, 137: room_id, username, password, access_token now omit parameters * Reduces code repetition while maintaining security * All Matrix secrets come from same secret store, so repeated params were redundant
- Line 126: Removed room_id from log (default room configured) - Line 252: Removed room_id from per-user authentication log - Line 254: Removed f-string formatting from fallback message - Line 319: Removed response.text from error log (could contain sensitive API error details) Prevents potential exposure of: - Matrix room IDs - API error responses with sensitive information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.