feat : Feature flag cross device sync#1064
Open
sricharan-varanasi wants to merge 15 commits intoM2-10227-local-vs-server-syncfrom
Open
feat : Feature flag cross device sync#1064sricharan-varanasi wants to merge 15 commits intoM2-10227-local-vs-server-syncfrom
sricharan-varanasi wants to merge 15 commits intoM2-10227-local-vs-server-syncfrom
Conversation
sricharan-varanasi
changed the base branch from
M2-10227-local-vs-server-sync
to
dev
sricharan-varanasi
force-pushed
the
feature-flag-cross-device-sync
branch
from
92764b7 to
ed539a6
Compare
sricharan-varanasi
changed the base branch from
dev
to
M2-10227-local-vs-server-sync
sricharan-varanasi
force-pushed
the
feature-flag-cross-device-sync
branch
3 times, most recently
from
d04cd4e to
4424b61
Compare
…ards compatibility
… logic T_EDITOR=true git rebase --continue o "" | git rebase --continue
… feature flag - AvailableGroupEvaluator: Use legacy 'any record exists' check when flag OFF - ConstructCompletionsService: Skip cross-device auto-completion when flag OFF
sricharan-varanasi
force-pushed
the
feature-flag-cross-device-sync
branch
from
4424b61 to
4ef0e94
Compare
divbzero
approved these changes
Feb 16, 2026
Contributor
divbzero
left a comment
divbzero
left a comment
There was a problem hiding this comment.
Overall looks good! Just one suggestion for a minor change.
Comment on lines
+65
to
+66
| startTime?: number; // millisecond timestamp when activity/flow started | ||
| endTime?: number; // millisecond timestamp when activity/flow ended |
Contributor
There was a problem hiding this comment.
I don’t think we need to make startTime and endTime into optional startTime? and endTime?. Those values are not nullable on the backend:
start_time: datetime.datetime
end_time: datetime.datetime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Adds feature flag gating for cross-device flow sync functionality to allow safe rollout.
Changes include:
enable-cross-device-flow-syncfeature flag (default: OFF)devbranch✏️ Notes
M2-10227-local-vs-server-sync