Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make includeDeprecated non nullable. #8124

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

michaelstaib
Copy link
Member

Closes #8094

@michaelstaib michaelstaib requested a review from Copilot March 13, 2025 08:35
@michaelstaib michaelstaib self-assigned this Mar 13, 2025
@michaelstaib michaelstaib added this to the HC-15.1.0 milestone Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the includeDeprecated argument to be non-nullable across introspection types to ensure consistent and clear usage.

  • Changed includeDeprecated type from nullable Boolean to non-nullable Boolean.
  • Removed redundant boolean type declarations in __Field.cs and __Directive.cs.
  • Updated default values to reflect the non-nullable change.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

File Description
src/HotChocolate/Core/src/Types/Types/Introspection/__Type.cs Updated includeDeprecated argument to use a non-nullable Boolean type and introduced nonNullBooleanType.
src/HotChocolate/Core/src/Types/Types/Introspection/__Field.cs Replaced nullable Boolean declaration with non-nullable Boolean for includeDeprecated.
src/HotChocolate/Core/src/Types/Types/Introspection/__Directive.cs Removed the redundant nullable Boolean type and updated includeDeprecated argument to non-nullable.
@michaelstaib michaelstaib added ⚖️ spec Implement or fix a GraphQL specification item. 💥 breaking-changes This PR contains breaking changes. 🍒 cherry-pick Consider cherry-picking these changes into the previous major version. and removed 🌶️ hot chocolate labels Mar 13, 2025
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.01%. Comparing base (33896d9) to head (9f7818f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8124      +/-   ##
==========================================
- Coverage   74.01%   74.01%   -0.01%     
==========================================
  Files        2664     2664              
  Lines      140294   140289       -5     
  Branches    16336    16336              
==========================================
- Hits       103844   103838       -6     
  Misses      30881    30881              
- Partials     5569     5570       +1     
Flag Coverage Δ
unittests 74.01% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@michaelstaib michaelstaib merged commit a98f680 into main Mar 13, 2025
5 checks passed
@michaelstaib michaelstaib deleted the mst/spec-includeDeprecated-nonnull branch March 13, 2025 09:36
michaelstaib added a commit that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 breaking-changes This PR contains breaking changes. 🍒 cherry-pick Consider cherry-picking these changes into the previous major version. 🌶️ hot chocolate ⚖️ spec Implement or fix a GraphQL specification item. 🌶️ strawberry shake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Spec Draft 1142
1 participant