-
-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make includeDeprecated
non nullable.
#8124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the includeDeprecated argument to be non-nullable across introspection types to ensure consistent and clear usage.
- Changed includeDeprecated type from nullable Boolean to non-nullable Boolean.
- Removed redundant boolean type declarations in __Field.cs and __Directive.cs.
- Updated default values to reflect the non-nullable change.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/HotChocolate/Core/src/Types/Types/Introspection/__Type.cs | Updated includeDeprecated argument to use a non-nullable Boolean type and introduced nonNullBooleanType. |
src/HotChocolate/Core/src/Types/Types/Introspection/__Field.cs | Replaced nullable Boolean declaration with non-nullable Boolean for includeDeprecated. |
src/HotChocolate/Core/src/Types/Types/Introspection/__Directive.cs | Removed the redundant nullable Boolean type and updated includeDeprecated argument to non-nullable. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8124 +/- ##
==========================================
- Coverage 74.01% 74.01% -0.01%
==========================================
Files 2664 2664
Lines 140294 140289 -5
Branches 16336 16336
==========================================
- Hits 103844 103838 -6
Misses 30881 30881
- Partials 5569 5570 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes #8094