Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Google optional authorization parameters. #15

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

martindufort
Copy link
Contributor

Add support for Google optional parameters:

  • login_hint: Suggest Google account email address to perform authorization with
  • include_granted_scopes: Include previously granted scopes in the authorization request.

Fix

Remove unused parameters in the LoginProvider and RefreshProvider

Tests

Add new tests to ensure AuthorizationURL is properly constructed

Cleanup functions to remove unneeded parameters
…ng the optional parameters in the constructed URL.
@mattmassicotte
Copy link
Contributor

Silly issue: the initialization function being used isn't available on some platforms. Adding one additional parameter can fix it. I'm going to attempt to add a commit that does that...

@mattmassicotte mattmassicotte merged commit b33e2e0 into ChimeHQ:main Nov 10, 2023
3 checks passed
@martindufort
Copy link
Contributor Author

Is everything all good?

@mattmassicotte
Copy link
Contributor

Yup everything is good. I've never pushed a commit to someone else's branch as part of a PR before. But it worked!

Thanks again for this, great change.

@martindufort martindufort deleted the fix-support-login-hint branch April 30, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants