Add close connection functionality to WebSocket client #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a graceful close connection function to the BinaryOptionsTools-v2 WebSocket client, addressing the need for proper connection management.
Changes Made
Core WebSocket Client (
crates/core/src/general/client.rs)shutdown_sender: Sender<()>field toWebSocketInnerClientfor signaling shutdownclose()method that gracefully terminates the connection:PocketOption Client (
crates/binary_options_tools/src/pocketoption/pocket_client.rs)close()method that delegates to the underlying WebSocket clientUsage
Users can now gracefully close connections:
Implementation Details
The implementation follows the existing patterns in the codebase and maintains backward compatibility while adding the requested close connection capability.
Fixes #16.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
demo-api-eu.po.market/home/REDACTED/work/BinaryOptionsTools-v2/BinaryOptionsTools-v2/target/debug/deps/binary_options_tools-bf0e6b2adb8abbb6 test_close_connection(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.