Merged
Conversation
e-bauman
commented
Feb 19, 2026
|
|
||
| self.hood_angle_sub = self.shot_tuner.getDoubleTopic("hood angle").publish() | ||
| self.flywheel_rps_sub = self.shot_tuner.getDoubleTopic("flywheel rps").publish() | ||
| self.hood_angle_sub = self.shot_tuner.getDoubleTopic("hood angle").subscribe(20.0) |
Contributor
Author
There was a problem hiding this comment.
are the variables reassigned intentionally?
im so sorry lord eben for not initializing the cancoder in init
Don't know if this is right at all
CHanged the way we do configs for the cancoder
Get_hood_angle assumed we returned a float so it converted it to a rotation but it was already a rotation. Is_hood_at_angle didn't get the value of the get_hood_angle status signal correctly so it highkey broke. added .value to fix dwdw
published the status signal not the value itself
i get a type error because the drivetrain angles are not rotation2ds. I changed the drivetrain angles to be rotation2ds. in your original commented out code, you just passed the drivetrain angles as 0 and it was also red. Was setshooter like that before?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.