Autometrics #3
Open
Autometrics #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qezz
reviewed
Dec 17, 2024
Comment on lines
+21
to
+33
| const REQUEST_SLO: Objective = | ||
| Objective::new("validator-request").success_rate(ObjectivePercentile::P99_9); | ||
|
|
||
| const SIGN_SLO: Objective = Objective::new("sign-request") | ||
| .success_rate(ObjectivePercentile::P99_9) | ||
| .latency(ObjectiveLatency::Ms500, ObjectivePercentile::P99) | ||
| .latency(ObjectiveLatency::Ms1000, ObjectivePercentile::P99_9); | ||
|
|
||
| const GET_PUBKEY_SLO: Objective = Objective::new("pubkey-request") | ||
| .success_rate(ObjectivePercentile::P99_9) | ||
| .latency(ObjectiveLatency::Ms500, ObjectivePercentile::P99) | ||
| .latency(ObjectiveLatency::Ms1000, ObjectivePercentile::P99_9); | ||
|
|
There was a problem hiding this comment.
ooh.. judging by https://docs.rs/autometrics/latest/autometrics/objectives/index.html, it's doing too much to my taste
i would personally not do this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements metrics, as requested here, and code does look very nice, but:
1-
autometricsis not maintained2- The generated metrics are.. not great.
By not great I mean:
0(so thedouble_signcounter is missing most of the time) -- this makes writing alerts harderchain_id), so it's not clear for which chain the metrics are relevant -- they are only usable for thetmkmsinstance.I would not merge this PR, it's here only to contrast #2