Replace QuaternaryChange types with ChangeSet#192
Merged
ChrisPulman merged 2 commits intomainfrom Feb 3, 2026
Merged
Conversation
Replace the custom QuaternaryChange/QuaternaryChangeSet/QuaternaryChangeReason API with the unified Change/ChangeSet model across the quaternary code. Removed QuaternaryChange*, QuaternaryChangeReason and QuaternaryChangeSet files and updated interfaces, events and observables (IQuad, QuadList, QuadDictionary, QuaternaryList, QuaternaryExtensions, SecondaryIndex, ReactiveView, etc.) to use Change<T>/ChangeSet<T>. Adjusted several APIs to use non-nullable item parameters and updated ReactiveView/indices to match. Also made a thread-safety tweak for subscriber tracking (volatile bool -> int with Interlocked) and simplified Connect() to return the unified Changes directly.
Remove per-shard ChangeSet/ItemChanged events and IObservable Changes from QuadList/QuadDictionary/IQuad and move change notification responsibility to the parent QuaternaryBase Stream pipeline. Add documentation clarifying quads are internal shard containers (no independent notifications). Introduce IQuaternarySource.Version for lightweight change detection, replace Interlocked.Exchange with Volatile.Write when marking Stream subscribers, remove direct System.Reactive.Linq dependencies, and add a few MethodImpl(AggressiveInlining) hints. Update extension methods and AutoRefresh to work with CacheNotify<T>/Stream semantics and simplify QuaternaryList constructor (no merging of shard observables). These changes centralize event delivery, reduce allocations, and clarify internal shard responsibilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the custom QuaternaryChange/QuaternaryChangeSet/QuaternaryChangeReason API with the unified Change/ChangeSet model across the quaternary code. Removed QuaternaryChange*, QuaternaryChangeReason and QuaternaryChangeSet files and updated interfaces, events and observables (IQuad, QuadList, QuadDictionary, QuaternaryList, QuaternaryExtensions, SecondaryIndex, ReactiveView, etc.) to use Change/ChangeSet.
Adjusted several APIs to use non-nullable item parameters and updated ReactiveView/indices to match.
Also made a thread-safety tweak for subscriber tracking (volatile bool -> int with Interlocked) and simplified Connect() to return the unified Changes directly.
Remove per-shard ChangeSet/ItemChanged events and IObservable Changes from QuadList/QuadDictionary/IQuad and move change notification responsibility to the parent QuaternaryBase Stream pipeline.
Add documentation clarifying quads are internal shard containers (no independent notifications).
Introduce IQuaternarySource.Version for lightweight change detection, replace Interlocked.Exchange with Volatile.Write when marking Stream subscribers, remove direct System.Reactive.Linq dependencies, and add a few MethodImpl(AggressiveInlining) hints. Update extension methods and AutoRefresh to work with CacheNotify/Stream semantics and simplify QuaternaryList constructor (no merging of shard observables).
These changes centralize event delivery, reduce allocations, and clarify internal shard responsibilities.