Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact form and social links added #141

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ananya-dhiman
Copy link
Contributor

@ananya-dhiman ananya-dhiman commented May 30, 2024

Added contact form

Feature #104

PR Description πŸ“œ

Modified about.html
Added social links and contact form


Mark the task you have completed βœ…

Added Social links
Added Contact form
Connection of form yet to be done (Email is not yet received after contacting @Durgesh4993 and verifciation needs to be done from recievr side)

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • [ x] I have added screenshot for review.

## Add your screenshots(Optional) πŸ“Έ

image



Thank you soo much for contributing to our repository πŸ’—

Copy link
Member

@Durgesh4993 Durgesh4993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflict file and add demo video

@Durgesh4993
Copy link
Member

add issue number

Copy link
Collaborator

@thevirengarg thevirengarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the structure of the contact form. Placement of the buttons, contact form fields are not aligned properly.

@ananya-dhiman
Copy link
Contributor Author

Ok, also I am using formsubmit.co for form submition to email so should i go ahead with that?

@ananya-dhiman ananya-dhiman changed the title Contact form and socila links added Contact form and social links added Jun 3, 2024
@thevirengarg
Copy link
Collaborator

Ok, also I am using formsubmit.co for form submition to email so should i go ahead with that?

Yes, you can go ahead with it.

@ananya-dhiman
Copy link
Contributor Author

I added a new PR for this same issue here Contact form and social links added (NEW) #177, pleasecheck that and I can close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants