Fix calculation of overlap_simple_bit_stream_size #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the "Stream truncated" error seen with a number of woff2 fonts. Currently the calculation of overlap_simple_bit_stream_size uses the same function as for bitmap_stream_length but in the specification the latter should be rounded up to the next 32bit boundary, and the former should be only to the next byte boundary. This simplifies/removes the bit_stream_byte_length function and uses the same inline calculation for this as the the woff2 reference decoder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "Stream truncated" error seen with a number of woff2 fonts. Currently the calculation of overlap_simple_bit_stream_size uses the same function as for bitmap_stream_length but in the specification the latter should be rounded up to the next 32bit boundary, and the former should be only to the next byte boundary.
This simplifies/removes the bit_stream_byte_length function and uses the same inline calculation for this as the the woff2 reference decoder.
I know there's not much activity in this repository, but leaving this here if anybody else hits this issue.