Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LLMs and Embedding models resources experience #21

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

trducng
Copy link
Contributor

@trducng trducng commented Apr 10, 2024

No description provided.

@trducng trducng requested a review from lone17 April 10, 2024 12:58
@trducng trducng self-assigned this Apr 10, 2024
Copy link
Contributor

@lone17 lone17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trducng trducng merged commit 3ed50b0 into main Apr 11, 2024
6 checks passed
@lone17 lone17 deleted the fix/default-value branch April 13, 2024 17:24
phv2312 pushed a commit to phv2312/kotaemon that referenced this pull request Sep 11, 2024
* Fix inconsistent default values
* Disallow LLM's empty name. Handle LLM creation error on UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants