-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow file selector to be disabled #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thank @trducng. Just had some small comments.
Also please update the docs and screenshots:
- https://github.com/Cinnamon/kotaemon/blob/main/docs/usage.md (step 3, guide them to select file index)
- https://github.com/Cinnamon/kotaemon/blob/main/docs/images/chat-tab.png
Should update the |
oh yes, would be nice if you could copy-paste the docs/usage.md file to that one. That one is currently used for hf hub deployment only so it's not that important. |
@lone17 I have updated, please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
One question though, should we auto select any newly added file ? If yes then let's address it in another PR, else please close #26.
I think we should keep the file selection explicit, since our app isn't a question answering demo, but a long-running app. |
* Allow file selector to be disabled * Update docs and variable names
No files will be considered during chat.
All files will be considered during chat.
Only selected files will be considered during chat. If no files are selected, no files will be considered.