Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Add ReAct and ReWOO Reasoning Pipelines #43

Merged
merged 16 commits into from
May 9, 2024

Conversation

cin-albert
Copy link
Collaborator

No description provided.

@cin-albert cin-albert requested a review from trducng April 22, 2024 07:46
@trducng trducng requested a review from taprosoft April 29, 2024 03:13
@lone17
Copy link
Contributor

lone17 commented Apr 29, 2024

After the comments are addressed, please hide these features from the app by default before merging. Then we can work on improving its UX in later PRs and enable it once it's nice enough to use by most users.

Or we can wait until the app has made a good impression with its basic features, then we enable this with a disclaimer that these would run slow and more costly. That way we didn't hurt the first impression while still being able to show off these features.

@trducng
Copy link
Contributor

trducng commented May 8, 2024

@taprosoft @cin-albert Outstanding work:

  1. Refactor the DocSearch into the Tool section in Kotaemon. Lower priority because it doesn't affect the user. At the same time it requires how we should formulate the tooling inside the app, which takes time. I think we should keep a ticket to it.
  2. The agent pipeline doesn't take into account of the chat history. Higher priority than 1. But I'm intending to work on the hybrid indexing (which is the highest priority), I think we can create a ticket for this issue.

@trducng trducng requested a review from taprosoft May 8, 2024 07:18
trducng
trducng previously approved these changes May 9, 2024
Copy link
Contributor

@trducng trducng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trducng trducng self-requested a review May 9, 2024 08:48
Copy link
Contributor

@trducng trducng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trducng trducng merged commit 466adf2 into Cinnamon:main May 9, 2024
3 checks passed
phv2312 pushed a commit to phv2312/kotaemon that referenced this pull request Sep 11, 2024
* Add ReactAgentPipeline by wrapping the ReactAgent

* Implement stream processing for ReactAgentPipeline and RewooAgentPipeline

* Fix highlight_citation in Rewoo and remove highlight_citation from React

* Fix importing ktem.llms inside kotaemon

* fix: Change Rewoo::solver's output to LLMInterface instead of plain text

* Add more user_settings to the RewooAgentPipeline

* Fix LLMTool

* Add more user_settings to the ReactAgentPipeline

* Minor fix

* Stream the react agent immediately

* Yield the Rewoo progress to info panel

* Hide the agent in flowsettings

* Remove redundant comments

---------

Co-authored-by: trducng <trungduc1992@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants