Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Show app version in the Help page #68

Merged
merged 5 commits into from
May 16, 2024
Merged

Feat: Show app version in the Help page #68

merged 5 commits into from
May 16, 2024

Conversation

lone17
Copy link
Contributor

@lone17 lone17 commented May 15, 2024

fix #69

@lone17 lone17 changed the title typo in deps list Feat: Show app version in the Help page May 15, 2024
@lone17 lone17 requested a review from trducng May 15, 2024 17:24
Copy link
Contributor

@trducng trducng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comment, everything looks good.

flowsettings.py Outdated Show resolved Hide resolved
@lone17 lone17 requested a review from trducng May 16, 2024 07:23
Copy link
Contributor

@trducng trducng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lone17 lone17 merged commit b2296cf into main May 16, 2024
6 checks passed
@lone17 lone17 deleted the fix/dep-typo branch May 16, 2024 07:27
phv2312 pushed a commit to phv2312/kotaemon that referenced this pull request Sep 11, 2024
* typo

* show version in the Help page

* update docs

* pump duckduckgo-search

* allow app version to be set by env var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display version number or PR name so that user could know when the current system updated
2 participants