Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the indexing pipeline to report the indexing progress onto the UI #81

Merged
merged 3 commits into from
May 25, 2024
Merged

Allow the indexing pipeline to report the indexing progress onto the UI #81

merged 3 commits into from
May 25, 2024

Conversation

trducng
Copy link
Contributor

@trducng trducng commented May 20, 2024

This PR:

  • Allows the indexing pipeline to show indexing progress.
  • List out successful and failed files.

image

@trducng trducng requested a review from lone17 May 20, 2024 15:57
lone17
lone17 suggested changes May 23, 2024
View reviewed changes
Copy link
Contributor

@lone17 lone17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trducng. Just few small changes and I think it's good for a minor version pump.

libs/ktem/ktem/index/file/pipelines.py Outdated Show resolved Hide resolved
libs/ktem/ktem/index/file/pipelines.py Outdated Show resolved Hide resolved
@trducng trducng requested a review from lone17 May 25, 2024 00:47
lone17
lone17 approved these changes May 25, 2024
View reviewed changes
Copy link
Contributor

@lone17 lone17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lone17 lone17 merged commit ebf1315 into main May 25, 2024
6 checks passed
@trducng trducng deleted the feat/upload-progress branch June 13, 2024 07:48
phv2312 pushed a commit to phv2312/kotaemon that referenced this pull request Sep 11, 2024
@trducng @phv2312
(pump:minor) Allow the indexing pipeline to report the indexing progr…
f42c39f 
…ess onto the UI (Cinnamon#81)

* Turn the file indexing event to generator to report progress

* Fix React text's trimming function

* Refactor delete file into a method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lone17 lone17 lone17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trducng @lone17