Improve migration docs - build code #230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #220 (into #220, #229 and #230) as CCI can't accept PRs that update the docs, examples and build code all in the same PR.
This PR updates the build code used for this orb to best take advantage of the v12 build capabilities (as described by the migration docs as of #220, as shown in the example as of #229) so that it doesn't do a "dev-publish" for forked-PRs (as they won't have access to the context this needs) and it only "pack"s if tests worked (no point packing if the build has failed).
This makes the build of this orb consistent with the build process that its documentation recommends.