Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOT_MERGE - update api to be compatible with the gelato relayer #210

Draft
wants to merge 46 commits into
base: main
Choose a base branch
from
Draft

NOT_MERGE - update api to be compatible with the gelato relayer #210

wants to merge 46 commits into from

Conversation

JacqueGM
Copy link
Contributor

@JacqueGM JacqueGM commented Oct 4, 2023

re-work tha api to be comptaible with the new relayer

@JacqueGM JacqueGM changed the title update api to be compatible with the gelato relayer NOT_MERGE - update api to be compatible with the gelato relayer Oct 4, 2023
@louilinn louilinn marked this pull request as draft October 5, 2023 09:01
llunaCreixent
llunaCreixent reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@llunaCreixent llunaCreixent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a good idea to add the docker services here in the api tests. The services integration is tested in the core tests.

@JacqueGM
Copy link
Contributor Author

maybe a better idea should be to mock the other relayr? I will ask Juanen

@llunaCreixent
Copy link
Member

maybe a better idea should be to mock the other relayr? I will ask Juanen

Yes, mocking sounds great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llunaCreixent llunaCreixent llunaCreixent left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JacqueGM @llunaCreixent @juanenrisley