Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logo on Welcome and Login page #704

Merged
merged 5 commits into from
Jul 13, 2023

Conversation

mikozet
Copy link
Collaborator

@mikozet mikozet commented Jun 29, 2023

No description provided.

@mikozet mikozet requested a review from louilinn June 29, 2023 12:52
@mikozet mikozet self-assigned this Jun 29, 2023
@mikozet mikozet linked an issue Jun 29, 2023 that may be closed by this pull request
@mikozet mikozet requested a review from juanenrisley July 3, 2023 06:10
Copy link
Collaborator

@louilinn louilinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now we are creating legacy code. Why keep the old logos?
Doesn't it make more sense to replace the old svg files of logo with new logo?

My suggestion:
If we are changing the log we should replace the circlesLogoSVG file
We should keep the Logo component.
We should not add the logo to icons file as it is not an icon, its the logo

@louilinn
Copy link
Collaborator

louilinn commented Jul 3, 2023

Let's put this on hold until we have confirmed if logo is changing fully or not. I've asked product in the issue

@triaslucia
Copy link

Things are not so organized as far as IO can see. There are currently 2 images existing. How this is named on the code, no idea. But for the outside we have two different “logo” images in the App.

Colourful C, turned down with "gang" on top
-Login
-Welcome

Circles logo (colorful C- in correct position)
-Favicon / tab icon
-Max transfer amount icon
-CirclesUBI payout "avatar" in activity log
-Saving the webapp to home screen on phone creates an icon image
-Validation loading screen
-Preview image in links

Necessity: we need to get rid of the Colorful C, turned down with "gang" on top. ASAP.
Proposal: clear up code/Assets, eliminate the Colorful C, turned down with "gang" on top, and use for now the . Circles logo (colorful C- in correct position) for all situations as
this is priority 1, in order to move forward with the guidelines

@netlify
Copy link

netlify bot commented Jul 10, 2023

Deploy Preview for preview-review-circles-garden ready!

Name Link
🔨 Latest commit 4672b64
🔍 Latest deploy log https://app.netlify.com/sites/preview-review-circles-garden/deploys/64ae7bbb03ac5f0008176f6f
😎 Deploy Preview https://deploy-preview-704.review.circles.garden
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mikozet mikozet requested a review from louilinn July 10, 2023 06:56
src/components/Logo.js Outdated Show resolved Hide resolved
src/components/Logo.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@juanenrisley juanenrisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏿

Copy link
Collaborator

@louilinn louilinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@louilinn louilinn changed the base branch from main to release July 13, 2023 08:25
@louilinn louilinn merged commit 3c50ce6 into release Jul 13, 2023
5 checks passed
@louilinn louilinn deleted the 703-change-illustration-on-welcome-and-log-in-page branch July 13, 2023 08:26
louilinn pushed a commit that referenced this pull request Jul 13, 2023
* Update logo on Welcome and Login page
mikozet added a commit that referenced this pull request Aug 16, 2023
* Update logo on Welcome and Login page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change illustration on Welcome and log in page
4 participants