Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove console errors on development #733

Conversation

mikozet
Copy link
Collaborator

@mikozet mikozet commented Sep 14, 2023

No description provided.

@mikozet mikozet self-assigned this Sep 14, 2023
@mikozet mikozet linked an issue Sep 14, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for preview-review-circles-garden ready!

Name Link
🔨 Latest commit 58c84de
🔍 Latest deploy log https://app.netlify.com/sites/preview-review-circles-garden/deploys/65156e48df94de0008a60874
😎 Deploy Preview https://deploy-preview-733.review.circles.garden
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@juanenrisley juanenrisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏿 LGTM lets see what @louilinn thinks

Copy link
Collaborator

@louilinn louilinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still get this error:

Uncaught (in promise) Error: Cannot destructure property 'skipDedupe' of '(intermediate value)(intermediate value)(intermediate value)' as it is null.
    at Gy (chunk-ZTBPADDD.js:24:37632)
    at chunk-ZTBPADDD.js:24:115595

Do you know why it is there?

We might as well fix all at once but also changes look fine and a quick check in UI I don't see any problem

@mikozet
Copy link
Collaborator Author

mikozet commented Sep 25, 2023

I still get this error:

Uncaught (in promise) Error: Cannot destructure property 'skipDedupe' of '(intermediate value)(intermediate value)(intermediate value)' as it is null.
    at Gy (chunk-ZTBPADDD.js:24:37632)
    at chunk-ZTBPADDD.js:24:115595

Do you know why it is there?

We might as well fix all at once but also changes look fine and a quick check in UI I don't see any problem

I do not see it, where do you see it and in which browser?

@louilinn
Copy link
Collaborator

Most likely it was a preview thing, sorry! You can ignore. I will merge it in the next release.
Thank you Miko!

@louilinn louilinn changed the base branch from main to release September 28, 2023 11:54
@louilinn louilinn force-pushed the 709-some-errors-on-during-local-development-which-could-be-corrected branch from a3512f9 to 4506060 Compare September 28, 2023 12:03
@louilinn louilinn force-pushed the 709-some-errors-on-during-local-development-which-could-be-corrected branch from 4506060 to 8c70ae8 Compare September 28, 2023 12:03
@louilinn louilinn merged commit 3d7dea6 into release Sep 28, 2023
5 checks passed
@louilinn louilinn deleted the 709-some-errors-on-during-local-development-which-could-be-corrected branch September 28, 2023 12:21
louilinn added a commit that referenced this pull request Sep 28, 2023
* Remove console errors on development

* Fix forward ref error

---------

Co-authored-by: Louise Linné <linne.louise@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some errors on during local development which could be corrected
3 participants