Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

765 note of transfers not appearing in activity log #767

Merged

Conversation

mikozet
Copy link
Collaborator

@mikozet mikozet commented Feb 24, 2024

Fix #765
Fix #757

  • Tested working notes for individual accounts and shared accounts
  • Checked if news are working and other activity log functionalities
  • Clicked through app for more veryfication and bug spotting
  • Notice duplicates in notifications whle sending, information doesn't clear properly - that one is current behaviour so it is not a result of this code being added - issue added here - Notification doesn't clear properly and repeating #768

@mikozet mikozet added the bug 💥 Something isn't working label Feb 24, 2024
@mikozet mikozet self-assigned this Feb 24, 2024
@mikozet mikozet linked an issue Feb 24, 2024 that may be closed by this pull request
Copy link

netlify bot commented Feb 24, 2024

Deploy Preview for preview-review-circles-garden ready!

Name Link
🔨 Latest commit f3327f0
🔍 Latest deploy log https://app.netlify.com/sites/preview-review-circles-garden/deploys/65dcd5bb148a1b0008eba963
😎 Deploy Preview https://deploy-preview-767--preview-review-circles-garden.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mikozet mikozet marked this pull request as ready for review February 26, 2024 10:08
Copy link
Member

@llunaCreixent llunaCreixent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@llunaCreixent llunaCreixent force-pushed the 765-note-of-transfers-not-appearing-in-activity-log branch from fae183c to f3327f0 Compare February 26, 2024 18:17
@llunaCreixent llunaCreixent merged commit 2c7f1f9 into main Feb 26, 2024
1 check passed
@llunaCreixent llunaCreixent deleted the 765-note-of-transfers-not-appearing-in-activity-log branch February 26, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 💥 Something isn't working
Projects
None yet
2 participants