Combining Vue Simulator Versioning PRs #337
Conversation
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
| // const { activeCircuit } = toRefs(simulatorStore) | ||
| name = name || 'Untitled' | ||
| name = stripTags(name) | ||
| scopeList[id].name = name |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
| scope.backups[scope.backups.length - 1] !== backup | ||
| ) { | ||
| scope.backups.push(backup) | ||
| scope.history = [] |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
| ) { | ||
| scope.backups.push(backup) | ||
| scope.history = [] | ||
| scope.timeStamp = new Date().getTime() |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
| */ | ||
| function loadModule(data, scope) { | ||
| // Create circuit element | ||
| var obj = new modules[rectifyObjectType(data.objectType)]( |
Check failure
Code scanning / CodeQL
Unvalidated dynamic method call High
… openProjectOffline
WalkthroughThe changes introduce a new build automation script, multiple Vue components for user interaction, and structured JSON files for configuration and data management. Key updates include a responsive navigation bar, various dialog boxes for project management, and enhanced user interface elements for circuit simulation. The overall structure emphasizes modularity and reusability across components, facilitating a more organized and efficient development process. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Navbar
participant DialogBox
participant ProjectStore
User->>Navbar: Clicks on project
Navbar->>DialogBox: Opens project dialog
DialogBox->>ProjectStore: Fetches project data
ProjectStore-->>DialogBox: Returns project data
DialogBox-->>User: Displays project options
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Fixes #372
Describe the changes you have made in this PR -
Combining all the PRs related to Vue simulator versioning
Screenshots of the changes (If any) -
#332 - Enable the Main simulator to dynamically load the Vue simulator.
#327 - build: script modification for different builds.
#327 - chore: adding versioned directory(v0 and v1).
Key Achievements:
Versioning Directories:
v0,v1, etc.) to manage multiple versions of the Vue simulator, allowing for independent development and maintenance of each version.Modifying the Build Script:
vite.config.v0.ts,vite.config.v1.ts) to ensure proper building and output management for each simulator version.Bash Script for Multi-Version Builds:
Hot-Swapping Vue Simulator Versions:
simverquery parameter, allowing users to seamlessly switch between different versions.Dynamic Script Injection:
createHtmlPluginin Vite, ensuring that the correct version-specific script tags are dynamically inserted into theindex.htmlduring the build process.Storing Simulator Version in Circuit Data:
circuit_datato store the simulator version, enabling circuits to be loaded with the appropriate simulator version based on their creation version.Redirecting to Correct Simulator Version:
simulatorVersionincircuit_data, ensuring compatibility and functionality.Creation of
index-cv.html:index-cv.htmlto serve as the entry point for the main repository, while the defaultindex.htmlcontinues to serve thecv-frontend-vuerepository, maintaining stability during development.Setting
v0as Default Simulator:v0as the default simulator version, ensuring consistency during the development process.Fixing Circuit Preview Image Issue:
Version-Specific Links for Launching Circuits:
Future Work:
/simulatorvueNote: Please check Allow edits from maintainers. if you would like us to assist in the PR.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Style