Skip to content
This repository has been archived by the owner on Jan 2, 2023. It is now read-only.

Pkspyder007 jsdoc action #11

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pkspyder007
Copy link
Contributor

Adding configuration file for jsdoc github action.

@pkspyder007 pkspyder007 reopened this Sep 14, 2020
@pkspyder007
Copy link
Contributor Author

@shubhankarsharma00 I have added the action file jsdoc and also added the sample config.json file for it.
I am new to this workflow stuff so please let me know if there are any problems.

@shubhankarsharma00
Copy link
Member

This looks good. You can take conf.json from the same branch I referred to before in the issue and also include relevant packages and scripts (jsdocs, jsdocs-interop, and better-docs theme).

@pkspyder007
Copy link
Contributor Author

@shubhankarsharma00 i'll try it and revert back to you.

@pkspyder007
Copy link
Contributor Author

pkspyder007 commented Sep 14, 2020

@shubhankarsharma00 Fixed #9 I have added the required packages and scripts from the mentioned repo.
Also ran the docs locally are they were generated without any error.

@shubhankarsharma00
Copy link
Member

Great work. ✌️

@pkspyder007
Copy link
Contributor Author

pkspyder007 commented Sep 14, 2020

@shubhankarsharma00 Thank you sir.
Is there anything else I need to do for the merging of this PR?

@shubhankarsharma00
Copy link
Member

@pkspyder007 this might be tricky because we haven't really decided where to host the documentation yet. But I think this PR in itself is complete and I will try to merge it soon. PS: No need to call me sir.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants