Treat trailing-delimiter as true by default

Cirras · Jan 18, 2025 · dba5d7a · dba5d7a
1 parent 901b559
commit dba5d7a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- Incorrect (de)serialization of some data structures containing arrays with trailing delimiters.
+
 ## [1.0.0-RC1] - 2024-10-20
 
 ### Added

diff --git a/protocol-code-generator/Generator.ObjectCodeGenerator.pas b/protocol-code-generator/Generator.ObjectCodeGenerator.pas
@@ -473,10 +473,6 @@ procedure TFieldCodeGenerator.ValidateArrayField;
   else if FDelimited then begin
     raise ECodeGenerationError.Create('Only arrays can be delimited.');
   end;
-
-  if not FDelimited and FTrailingDelimiter then begin
-    raise ECodeGenerationError.Create('Only delimited arrays can have a trailing delimiter.');
-  end;
 end;
 
 procedure TFieldCodeGenerator.ValidateLengthField;
@@ -1801,7 +1797,7 @@ procedure TObjectCodeGenerator.GenerateArray(Instruction: TDOMElement);
       .Comment(GetComment(Instruction))
       .ArrayField(True)
       .Delimited(Delimited)
-      .TrailingDelimiter(GetBooleanAttribute(Instruction, 'trailing-delimiter'))
+      .TrailingDelimiter(GetBooleanAttribute(Instruction, 'trailing-delimiter', True))
       .Build;
 
   try