Fix infinite loop when scanning some DMG archives #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When decompressing a zlib stream, it's possible to reach end of stream before running out of available bytes. In the DMG parser, this may cause an infinite loop. This commit adds a check for the condition where stream has ended before running out of input. Fixes: Cisco-Talos#925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this was already reviewed internally and included in:
This PR is just to fix it in
mainnow towards 1.2.0.When decompressing a zlib stream, it's possible to reach end of stream before running out of available bytes. In the DMG parser, this may cause an infinite loop.
This commit adds a check for the condition where stream has ended before running out of input.
Fixes: #925