Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UDF file support #941

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Add UDF file support #941

merged 1 commit into from
Aug 3, 2023

Conversation

ragusaa
Copy link
Contributor

@ragusaa ragusaa commented Jun 2, 2023 •
edited
Loading

Add support for the Beginning Area Descriptor (BEA01) UDF files.

@ragusaa ragusaa changed the title blah Add UDF file support Jun 2, 2023
@ragusaa ragusaa mentioned this pull request Jun 2, 2023
Closed
micahsnyder
micahsnyder requested changes Jun 24, 2023
View reviewed changes
Copy link
Contributor

@micahsnyder micahsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested yet, but from code review these are things I noticed.

libclamav/dconf.c Outdated Show resolved Hide resolved
libclamav/filetypes.c Outdated Show resolved Hide resolved
libclamav/filetypes.h Show resolved Hide resolved
libclamav/scanners.c Outdated Show resolved Hide resolved
libclamav/udf.c Outdated Show resolved Hide resolved
libclamav/udf.c Show resolved Hide resolved
libclamav/udf.c Show resolved Hide resolved
libclamav/udf.c Show resolved Hide resolved
libclamav/udf.c Show resolved Hide resolved
libclamav/udf.c Show resolved Hide resolved
ragusaa
ragusaa commented Jun 27, 2023
View reviewed changes
libclamav/filetypes_int.h Outdated Show resolved Hide resolved
@ragusaa ragusaa self-assigned this Jul 6, 2023
@ragusaa ragusaa force-pushed the CLAM-1931-AddUDFSupport branch 3 times, most recently from 003632c to 071971f Compare July 7, 2023 22:18
@micahsnyder micahsnyder mentioned this pull request Jul 18, 2023
Merged
micahsnyder
micahsnyder reviewed Jul 18, 2023
View reviewed changes
libclamav/udf.c Outdated Show resolved Hide resolved
@micahsnyder micahsnyder self-requested a review July 19, 2023 19:21
@ragusaa ragusaa force-pushed the CLAM-1931-AddUDFSupport branch 2 times, most recently from b1b8370 to 4f265dd Compare July 28, 2023 02:56
micahsnyder
micahsnyder requested changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@micahsnyder micahsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more things.

libclamav/udf.h Outdated Show resolved Hide resolved
libclamav/udf.h Outdated Show resolved Hide resolved
libclamav/udf.h Outdated Show resolved Hide resolved
libclamav/udf.h Outdated Show resolved Hide resolved
libclamav/udf.h Outdated Show resolved Hide resolved
libclamav/udf.h Outdated Show resolved Hide resolved
libclamav/udf.h Outdated Show resolved Hide resolved
libclamav/udf.h Outdated Show resolved Hide resolved
libclamav/udf.c Outdated Show resolved Hide resolved
micahsnyder
micahsnyder approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@micahsnyder micahsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review looks good. Manual testing looks good (notes in Jira under CLAM-2322). I'm happy. Waiting to see it pass through existing Jenkins build/tests. As noted, we don't have a benign sample to test with, so no automated test at this time.

@ragusaa @micahsnyder
Add support for UDF files
2ca8903 
Add support for specifically for Beginning Extended Area Descriptor
(BEA01) type of UDF files.
@micahsnyder
Copy link
Contributor

rebased because jenkins macos build failed because of openssl3 changes

@micahsnyder micahsnyder merged commit b4f0836 into Cisco-Talos:main Aug 3, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micahsnyder micahsnyder micahsnyder approved these changes

Assignees

@ragusaa ragusaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ragusaa @micahsnyder