Clam 2410 recent coverity issues #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragusaa
approved these changes
Aug 15, 2023
`cli_getpagesize()` may return -1 in an error condition. If it does, let's just treat it as 4096. I believe the actual coverity complaint is a false positive, but it's fair to account for the error case and this should shut it up.
On error `getmaxyx()` may set the output params to -1. We must check for this before treating the result as unsigned.
The `read()` function doesn't null terminate the `nwatch_str`, but `strtol` requires it to be NULL-terminated.
In aspack decrypt function, there's a check to make sure that backbytes doesn't exceed 57, because it is used as an index in init_array. However, it is mathematically impossible. So this commit removes the check.
Somehow forgot to save and commit final error handling check on the new set_tls_client_certificate() function. This change is needed to have Freshclam fail if you try to use the new client certificate environment variables incorrectly.
micahsnyder
force-pushed
the
CLAM-2410-recent-coverity-issues
branch
from
17eefa5
to
9581ed6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.